unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: Proposed extension of show-paren-mode: Highlight parens when point is in L or R margin.
Date: Thu, 16 Oct 2014 20:14:57 -0400	[thread overview]
Message-ID: <jwvegu7o8ua.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20141016212648.GG3421@acm.acm> (Alan Mackenzie's message of "Thu, 16 Oct 2014 21:26:48 +0000")

>> Otherwise it seems way too weird/ad-hoc to hardcode it, so make
>> it dependent on a config var.
> I think that our marginal utility will drop off very sharply, the more
> complicated our configurability becomes.

The purpose is not really to make it configurable, but to isolate the
code that provides this part of the functionality.

> Since point is on the same line as the paren, and is in the WS at either
> BOL or EOL, and the (at most) two eligible parameters are on the edge of
> the "core", point can't be between the two candidates.  The nearest one
> is clear, surely.

Right, I was thinking about the case in my suggestion of highlighting
the closing paren in at the end of the previous line.

> Hmm.  The :prefix keyword for `defgroup' is not mentioned in the doc
> string for `defcustom' (which is where `defgroup' points you for details
> of keywords).

I think the :prefix only makes sense for defgroup, not for defcustom.
Many keywords are like that, so maybe defgroup shouldn't delegate to
defcustom's docstring.

> I've removed all the instances of :group.

Thanks.

> Done.  (More precisely, a function to do the check is called directly
> from s-p--categorize-p).

Yup, looks nice, thanks.


        Stefan



  reply	other threads:[~2014-10-17  0:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11 13:43 Proposed extension of show-paren-mode: Highlight parens when point is in L or R margin Alan Mackenzie
2014-10-11 14:21 ` Eli Zaretskii
2014-10-12  8:39   ` Alan Mackenzie
2014-10-12  8:55     ` David Kastrup
2014-10-12  9:25       ` Alan Mackenzie
2014-10-12  9:01     ` Eli Zaretskii
2014-10-12 10:18       ` Alan Mackenzie
2014-10-12  4:12 ` Stefan Monnier
2014-10-12 10:04   ` Alan Mackenzie
2014-10-14 17:49     ` Stefan Monnier
2014-10-14 18:32       ` John Yates
2014-10-15  9:12       ` Alan Mackenzie
2014-10-15 22:38         ` Andy Moreton
2014-10-16  2:43         ` Stefan Monnier
2014-10-16  9:53           ` Alan Mackenzie
2014-10-16 12:59             ` Stefan Monnier
2014-10-16 13:31               ` Alan Mackenzie
2014-10-16 14:37                 ` Stefan Monnier
2014-10-16 15:46                   ` Alan Mackenzie
2014-10-16 17:40                     ` Stefan Monnier
2014-10-16 21:26                       ` Alan Mackenzie
2014-10-17  0:14                         ` Stefan Monnier [this message]
2014-10-14 21:50 ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvegu7o8ua.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).