From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Generalizing find-definition Date: Wed, 19 Nov 2014 09:27:58 -0500 Message-ID: References: <20141102151524.0d9c665c@forcix> <20141117211039.37f03409@forcix> <85ppclgcec.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416407323 5495 80.91.229.3 (19 Nov 2014 14:28:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Nov 2014 14:28:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 19 15:28:33 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xr6FD-0002hW-3c for ged-emacs-devel@m.gmane.org; Wed, 19 Nov 2014 15:28:31 +0100 Original-Received: from localhost ([::1]:58716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr6FC-00084z-MK for ged-emacs-devel@m.gmane.org; Wed, 19 Nov 2014 09:28:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr6Eq-0007Pb-Jb for emacs-devel@gnu.org; Wed, 19 Nov 2014 09:28:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xr6Ej-0007Yn-5i for emacs-devel@gnu.org; Wed, 19 Nov 2014 09:28:08 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:37627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xr6Ej-0007Yc-1a for emacs-devel@gnu.org; Wed, 19 Nov 2014 09:28:01 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sAJERxbo025044; Wed, 19 Nov 2014 09:27:59 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D3A5F62BA; Wed, 19 Nov 2014 09:27:58 -0500 (EST) In-Reply-To: <85ppclgcec.fsf@stephe-leake.org> (Stephen Leake's message of "Tue, 18 Nov 2014 02:07:23 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5130=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5130> : inlines <1542> : streams <1345154> : uri <1835302> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177752 Archived-At: >> +(defvar find-definition-function nil >> +(defvar find-definition-identifier-function nil > These variables will be set by the major mode, so they should be > buffer-local; use defvar-local. Bad idea: if the major modes set those with `setq' rather than with `setq-local', they'll end up setting the global value if the `setq' happens to be run before loading find-definition.el (which is quite possible since find-definition.el will typically be loaded via an autoload rather than via a `require'). Stefan