From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] image-mode.el (image-kill-buffer): New command. Date: Wed, 04 Feb 2015 21:15:42 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423102564 12599 80.91.229.3 (5 Feb 2015 02:16:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 02:16:04 +0000 (UTC) Cc: emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 03:16:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJBz2-0005Ra-6C for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 03:15:56 +0100 Original-Received: from localhost ([::1]:39720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJBz1-0001C3-9c for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 21:15:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJByx-0001Bw-VE for emacs-devel@gnu.org; Wed, 04 Feb 2015 21:15:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJBys-0003B7-Pv for emacs-devel@gnu.org; Wed, 04 Feb 2015 21:15:51 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJBys-00039t-GN for emacs-devel@gnu.org; Wed, 04 Feb 2015 21:15:46 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t152FfFv006649; Wed, 4 Feb 2015 21:15:41 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 2D67BAE124; Wed, 4 Feb 2015 21:15:42 -0500 (EST) In-Reply-To: (Artur Malabarba's message of "Wed, 4 Feb 2015 23:04:15 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5207=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5207> : inlines <2034> : streams <1384906> : uri <1846624> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182420 Archived-At: >> Given how similar docview and image-mode are, I'm always taken >> off-guard when I run into a small difference. This patch fixes one. They should share more behavior *and* code. > + * image-mode.el (image-kill-buffer): New command. > + (image-mode-map): Bind it to k. Could you try and remove the "k" binding in doc-view-map (i.e. let it inherit from image-mode-map)? Stefan