From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, phillip.lord@russet.org.uk
Subject: Re: Calling Lisp from undo.c's record_* functions
Date: Tue, 17 Nov 2015 14:09:36 -0500 [thread overview]
Message-ID: <jwvegfoigxp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8337w4bj53.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Nov 2015 20:00:56 +0200")
> Did you take a look at subst-char-in-region? It calls
> prepare_to_modify_buffer from within a loop which seems to assume that
> (a) gap position doesn't move, and (b) that pointer into buffer text
> is valid across the call to prepare_to_modify_buffer. GC could
> invalidate both assumptions, no?
[...]
> Bottom line: I think all the functions that manipulate the gap should
> be carefully audited to identify any potential problem with this
> approach.
prepare_to_modify_buffer runs before-change-functions, so it's been
running Elisp code for many years. Maybe there are still problems
lurking, but I'm not too worried and they'd have to be fixed regardless
of what we do with run_undoable_change.
Stefan
next prev parent reply other threads:[~2015-11-17 19:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 16:46 Calling Lisp from undo.c's record_* functions Eli Zaretskii
2015-11-16 21:51 ` Phillip Lord
2015-11-16 22:51 ` Stefan Monnier
2015-11-17 12:14 ` Phillip Lord
2015-11-17 13:46 ` Stefan Monnier
2015-11-17 14:42 ` Phillip Lord
2015-11-17 15:40 ` Stefan Monnier
2015-11-17 16:24 ` Eli Zaretskii
2015-11-17 16:49 ` Stefan Monnier
2015-11-17 17:05 ` Eli Zaretskii
2015-11-17 17:34 ` Stefan Monnier
2015-11-17 18:00 ` Eli Zaretskii
2015-11-17 19:09 ` Stefan Monnier [this message]
2015-11-17 19:22 ` Eli Zaretskii
2015-11-17 21:05 ` Phillip Lord
2015-11-17 21:02 ` Phillip Lord
2015-11-18 2:55 ` Stefan Monnier
2015-11-18 12:26 ` Phillip Lord
2015-11-17 16:35 ` Eli Zaretskii
2015-11-17 20:52 ` Phillip Lord
2015-11-18 3:38 ` Eli Zaretskii
2015-11-18 9:56 ` Phillip Lord
2015-11-18 10:49 ` David Kastrup
2015-11-18 17:30 ` Eli Zaretskii
2015-11-17 16:40 ` Eli Zaretskii
2015-11-17 16:51 ` Stefan Monnier
2015-11-17 19:44 ` Eli Zaretskii
2015-11-17 21:35 ` Phillip Lord
2015-11-18 2:52 ` Stefan Monnier
2015-11-18 3:49 ` Eli Zaretskii
2015-11-18 12:31 ` Phillip Lord
2015-11-18 17:49 ` Eli Zaretskii
2015-11-19 1:49 ` Stefan Monnier
2015-11-19 10:16 ` Phillip Lord
2015-11-19 15:53 ` Eli Zaretskii
2015-11-19 17:49 ` Stefan Monnier
2015-11-19 17:58 ` Eli Zaretskii
2015-11-19 18:17 ` Stefan Monnier
2015-11-22 21:44 ` Phillip Lord
2015-11-22 22:41 ` John Wiegley
2015-11-23 17:29 ` Phillip Lord
2015-11-23 3:37 ` Eli Zaretskii
2015-11-23 17:28 ` Phillip Lord
2015-11-25 17:43 ` Eli Zaretskii
2015-11-25 22:51 ` Richard Stallman
2015-11-26 10:27 ` Phillip Lord
2015-11-17 21:13 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvegfoigxp.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).