unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Something weird with when-let*/if-let*
Date: Sat, 14 Oct 2017 16:42:24 -0400	[thread overview]
Message-ID: <jwvefq54g75.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 8760bh1oqj.fsf@ericabrahamsen.net

> Besides message.el, nnimap.el is the only gnus lib to use when-let*.
> I can just add another subr-x require in nnimap for now -- if it starts

That's indeed what should be done, regardless of what message.el does:
if a foo.el uses a macro defined in bar.el, it should generally require
that bar.el directly rather than rely on some toto.el file to load it.

I'm not saying that we follow this rule all the time, but in my
experience, this is a sane rule to follow.  The downside is really
negligible: if foo.el requires foo.el which also requires bar.el, the
extra/redundant (require 'bar) will cost very little anyway.


        Stefan




  parent reply	other threads:[~2017-10-14 20:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14 12:10 Something weird with when-let*/if-let* Eric Abrahamsen
2017-10-14 13:10 ` Noam Postavsky
2017-10-14 13:12   ` Eric Abrahamsen
2017-10-14 13:47     ` Noam Postavsky
2017-10-14 13:49       ` Noam Postavsky
2017-10-14 19:13         ` Eric Abrahamsen
2017-10-14 19:55           ` Noam Postavsky
2017-10-14 20:03             ` Eric Abrahamsen
2017-10-14 20:05               ` Eric Abrahamsen
2017-10-14 20:42               ` Stefan Monnier [this message]
2017-10-16  3:23                 ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvefq54g75.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).