From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 f274cbd: Avoid reordering of output in 'shr-insert-document' Date: Sun, 17 Dec 2017 22:09:10 -0500 Message-ID: References: <20171216141055.30854.67661@vcs0.savannah.gnu.org> <20171216141056.8391A24612@vcs0.savannah.gnu.org> <83bmiyslq7.fsf@gnu.org> <83a7yhqrys.fsf@gnu.org> <5A36AF3D.8040406@gmx.at> <83zi6hp0j9.fsf@gnu.org> <5A36DFBB.4060801@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513566485 30933 195.159.176.226 (18 Dec 2017 03:08:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Dec 2017 03:08:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 18 04:08:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQlmZ-0007VZ-Ud for ged-emacs-devel@m.gmane.org; Mon, 18 Dec 2017 04:08:00 +0100 Original-Received: from localhost ([::1]:56502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQloW-0002GU-C0 for ged-emacs-devel@m.gmane.org; Sun, 17 Dec 2017 22:10:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQlnx-0002GK-Vl for emacs-devel@gnu.org; Sun, 17 Dec 2017 22:09:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQlnu-0002hi-0q for emacs-devel@gnu.org; Sun, 17 Dec 2017 22:09:25 -0500 Original-Received: from [195.159.176.226] (port=58296 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQlnt-0002h7-Pl for emacs-devel@gnu.org; Sun, 17 Dec 2017 22:09:21 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eQllt-0004jM-DZ for emacs-devel@gnu.org; Mon, 18 Dec 2017 04:07:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 14 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:Mx4d07jl/RyuyDF/zqheIClOc1Y= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221203 Archived-At: >> If we do that, then why use save-window-excursion in the first place? >> That's what it's supposed to preserve (among other things), right? > Not really. The Elisp manual says about `save-window-excursion' that I think what Eli is getting at is that instead of save-window-excursion we could just do add a `set-window-buffer` before `set-window-point`. I think it would make a lot of sense, actually, since save-window-excursion saves the whole window-config (i.e. data about all windows in the current frame), whereas we're only going to touch the selected window. Stefan