From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: GNU ELPA package for CC-mode Date: Thu, 23 Aug 2018 01:25:00 -0400 Message-ID: References: <20180819204918.GA3934@ACM> <20180821162043.GA3946@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535002430 6601 195.159.176.226 (23 Aug 2018 05:33:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 23 Aug 2018 05:33:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 23 07:33:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsiFe-0001dG-23 for ged-emacs-devel@m.gmane.org; Thu, 23 Aug 2018 07:33:46 +0200 Original-Received: from localhost ([::1]:34467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsiHk-0001iy-Lp for ged-emacs-devel@m.gmane.org; Thu, 23 Aug 2018 01:35:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsiGw-0001YR-TI for emacs-devel@gnu.org; Thu, 23 Aug 2018 01:35:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsi7D-0001OG-2d for emacs-devel@gnu.org; Thu, 23 Aug 2018 01:25:06 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:41530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsi7C-0001Mm-Ub for emacs-devel@gnu.org; Thu, 23 Aug 2018 01:25:03 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w7N5P156024654; Thu, 23 Aug 2018 01:25:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DF77169F6C; Thu, 23 Aug 2018 01:25:00 -0400 (EDT) In-Reply-To: <20180821162043.GA3946@ACM> (Alan Mackenzie's message of "Tue, 21 Aug 2018 16:20:43 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6357=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6357> : inlines <6826> : streams <1796298> : uri <2694139> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228840 Archived-At: >> Search for "5.33" in the cc-mode.el of the master branch. > Ah. So it's metadata written into a source file. I'm against this. > Would it not be possible to store the version number elsewhere? > Metadata in ordinary files is ugly and causes problems. A significant > one being that VCS logs get polluted by updates of metadata, making it > unpleasant, or even difficult, to use a log display. Not sure I understand: we currently have (defconst c-version "5.33.1" in cc-defs.el. In which way is this different? > This "Version:" header certainly has no place in master, though I can > see an argument being made for it being included in an ELPA version of > CC Mode. The purpose of this "Version:" header is to document for package.el which version of the cc-mode package is bundled with Emacs so that it can decide whether some other cc-mode ELPA package is more or less recent (and hence whether to activate that other package or not). So it very much belongs in `master`. >> The generation of the new package happens when the "Version:" header >> changes, so I don't think we want this header to be auto-generated on >> every commit. > "Changes" is a verb with an agent. Under what scenario do you envisage > this version number being changed? Someone pushed a commit which changes that part of the file. > Automatically upon a CC Mode commit to master is what I thought you > had in mind. Are you suggesting doing this by hand when it takes > somebody's fancy? Right: when you decide the code deserves a new GNU ELPA release. Stefan