From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: compile.el legacy compatibility Date: Sun, 24 Mar 2019 13:51:04 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="29871"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 24 18:51:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h87HP-0007eN-CU for ged-emacs-devel@m.gmane.org; Sun, 24 Mar 2019 18:51:31 +0100 Original-Received: from localhost ([127.0.0.1]:59066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h87HO-00073h-9M for ged-emacs-devel@m.gmane.org; Sun, 24 Mar 2019 13:51:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h87HI-00073c-4T for emacs-devel@gnu.org; Sun, 24 Mar 2019 13:51:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h87HH-0003sm-8E for emacs-devel@gnu.org; Sun, 24 Mar 2019 13:51:24 -0400 Original-Received: from [195.159.176.226] (port=46304 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h87HG-0003rv-Ch for emacs-devel@gnu.org; Sun, 24 Mar 2019 13:51:22 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h87H9-0007Hu-9u for emacs-devel@gnu.org; Sun, 24 Mar 2019 18:51:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:SCf3Oi9hluPVwm88ZzIE0eoiH4A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234688 Archived-At: > I was wondering what is your policy on removing obsolete content. I think > it would be a much better for current users if "line" was handled like all > the other fields instead of reverting the entire error to legacy mode in an > undocumented way. This current case can be handled as follows (by order of my own preferences): - Drop this old compatibility. - Refine the compatibility check: the old code only allowed (FILE LINE COLUMN) and not the more general (BEG-LINE . END-LINE) case, so we could still support the old (FILE LINE COLUMN) case where LINE is a function while also supporting the case where LINE is (BEG-LINE . END-LINE) and BEG-LINE and END-LINE can be functions. - Refine the compatibility by catching a `wrong-number-of-arguments` error when calling the LINE function with 2 args and considering it a tell-tale sign that it's not an old-style LINE function but a new-style function instead. - Refine the compatibility by catching a `wrong-number-of-arguments` error when calling the LINE function with 0 args and considering it a sign that it's probably an old-style LINE function. Stefan