From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Mon, 25 Mar 2019 12:50:45 -0400 Message-ID: References: <8736nbip4l.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256009"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 17:51:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8SoT-0014Up-G0 for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 17:51:05 +0100 Original-Received: from localhost ([127.0.0.1]:45596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8SoS-0003L5-I2 for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 12:51:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8SoH-0003HS-H9 for emacs-devel@gnu.org; Mon, 25 Mar 2019 12:50:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8SoG-0004eS-KT for emacs-devel@gnu.org; Mon, 25 Mar 2019 12:50:53 -0400 Original-Received: from [195.159.176.226] (port=35326 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8SoG-0004dd-BQ for emacs-devel@gnu.org; Mon, 25 Mar 2019 12:50:52 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h8SoE-0014Cz-VN for emacs-devel@gnu.org; Mon, 25 Mar 2019 17:50:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:LhBX+E49Nl2ycMnIrXkvGr59oVo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234709 Archived-At: >> While looking into bug#34973, bug#34974, and bug#34987, I accumulated >> the attached changes to lisp/gnus/gnus-dup.el which I would like to push >> to master. WDYT? > > Given the games Gnus plays with bindings (see `defvoo' and `deffoo') the > switch to lexical binding for gnus may prove to be complex. > > It would be better to avoid switching to lexical binding for a single > file in gnus: rather, do that as part of a larger effort to switch all > of gnus over to lexical binding. FWIW, I've been compiling Gnus using lexical-binding for many years now, and it's the MUA I use to spam this mailing-list, so at least the main "read&write messages" works fine for the nnimap and nntp backends. I think the def[fv]oo hacks don't get in the way of lexical-binding at all. Stefan