From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: pull requests
Date: Fri, 27 Mar 2020 10:05:37 -0400 [thread overview]
Message-ID: <jwveetdzyr6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <7b0e82fd-8928-26d2-4bed-331593685f36@gmail.com> ("Clément Pit-Claudel"'s message of "Fri, 27 Mar 2020 09:00:10 -0400")
>> More importantly, given that I did a review
>> of such a remote branch, how do I communicate my comments so that they
>> are recorded for posterity? Probably by email, so that doesn't seem
>> to solve the main problem of avoiding email in the patch submission
>> and review workflow.
>
> Assuming you use the web UI, you can typically attach comments to code regions.
I never use those web UIs when reviewing Git branches.
Instead, I fetch those branches with Git and then review them locally
(thank god!).
> Pros over email reviews include the fact that the comments remain attached
> to the code even after the patch is updated (so if the original author
> updates an unrelated section of the patch the comments don't disappear) and
> the fact that you get to see the full code, rather than just the patch.
>
> Cons include inferior text-editing capabilities, and inferior code browsing
> capabilities compared to applying the patch and browsing around in Emacs
> (but you can always checkout the branch, which I find nicer than applying
> patches by hand anyway).
My foggy memory says there was tool (developed by Google, maybe?) that
standardized a representation of annotations to store inside the Git
repository, so you could get both benefits (i.e. write your annotations
locally with the tool you like and then store them for posterity
attached to the code).
I can't remember its name any more (and I never used it).
Stefan
next prev parent reply other threads:[~2020-03-27 14:05 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 22:35 ELPA: where is chess developed? Jack Hill
2020-03-23 4:26 ` John Wiegley
2020-03-23 13:50 ` dick.r.chiang
2020-03-23 14:27 ` Mario Lang
2020-03-23 15:12 ` dick.r.chiang
2020-03-24 8:10 ` Philippe Vaucher
2020-03-24 11:38 ` dick.r.chiang
2020-03-24 11:54 ` Philippe Vaucher
2020-03-24 14:12 ` Stefan Monnier
2020-03-24 14:41 ` Stefan Monnier
2020-03-27 2:59 ` pull requests Richard Stallman
2020-03-27 3:49 ` Stefan Monnier
2020-03-28 2:45 ` Richard Stallman
2020-03-28 3:03 ` Stefan Monnier
2020-03-27 7:54 ` Eli Zaretskii
2020-03-27 13:00 ` Clément Pit-Claudel
2020-03-27 13:30 ` Eli Zaretskii
2020-03-27 14:37 ` Clément Pit-Claudel
2020-03-27 15:21 ` Eli Zaretskii
2020-03-27 15:41 ` Dmitry Gutov
2020-03-27 19:16 ` Eli Zaretskii
2020-03-27 19:24 ` Dmitry Gutov
2020-03-27 19:34 ` 조성빈
2020-03-27 19:28 ` Eli Zaretskii
2020-03-27 20:39 ` Dmitry Gutov
2020-03-28 2:46 ` Richard Stallman
2020-03-28 17:14 ` Dmitry Gutov
2020-03-30 3:38 ` Richard Stallman
2020-03-30 4:09 ` Stefan Monnier
2020-03-30 5:58 ` Eli Zaretskii
2020-03-30 12:03 ` Dmitry Gutov
2020-03-30 12:55 ` Yuri Khan
2020-03-30 13:12 ` Eli Zaretskii
2020-03-30 13:50 ` Dmitry Gutov
2020-03-30 14:12 ` Eli Zaretskii
2020-03-30 14:34 ` Dmitry Gutov
2020-03-30 15:36 ` Eli Zaretskii
2020-03-30 15:50 ` Dmitry Gutov
2020-03-30 16:09 ` Eli Zaretskii
2020-03-30 17:06 ` Dmitry Gutov
2020-03-30 17:13 ` Eli Zaretskii
2020-04-02 2:39 ` Richard Stallman
2020-04-17 3:54 ` Dmitry Gutov
2020-03-30 13:43 ` Stefan Monnier
2020-03-30 16:59 ` Dmitry Gutov
2020-03-30 17:20 ` Stefan Monnier
2020-03-30 17:28 ` Dmitry Gutov
2020-03-30 8:25 ` 조성빈
2020-03-30 11:51 ` Dmitry Gutov
2020-03-30 13:04 ` Eli Zaretskii
2020-03-30 17:49 ` Dmitry Gutov
2020-03-27 16:39 ` Clément Pit-Claudel
2020-03-27 19:21 ` Eli Zaretskii
2020-03-27 14:05 ` Stefan Monnier [this message]
2020-03-28 2:46 ` Richard Stallman
2020-03-23 15:58 ` ELPA: where is chess developed? Stefan Monnier
2020-03-23 14:25 ` Mario Lang
-- strict thread matches above, loose matches on Subject: below --
2020-04-17 4:24 pull requests Zach Pearson
2020-04-17 8:11 ` Alex Ott
2020-04-17 16:36 ` Dmitry Gutov
2020-04-21 1:47 ` Richard Stallman
2020-04-21 2:12 ` Po Lu
2020-04-22 3:19 ` Richard Stallman
2020-04-23 3:15 ` Po Lu
2020-04-17 16:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwveetdzyr6.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cpitclaudel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).