From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-27 30a7ee5: Fix Arabic shaping when eww/shr fill the text to be rendered Date: Fri, 05 Jun 2020 11:20:37 -0400 Message-ID: References: <20200605075722.16213.57047@vcs0.savannah.gnu.org> <20200605075724.3C52120A26@vcs0.savannah.gnu.org> <83y2p1a91g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 05 17:21:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhEA2-00098m-GL for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 17:21:34 +0200 Original-Received: from localhost ([::1]:36056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhEA1-0006eK-FX for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 11:21:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhE9C-000679-UT for emacs-devel@gnu.org; Fri, 05 Jun 2020 11:20:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhE9B-0005e5-Hk; Fri, 05 Jun 2020 11:20:42 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B3C4510033A; Fri, 5 Jun 2020 11:20:39 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0D82410031F; Fri, 5 Jun 2020 11:20:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1591370438; bh=P5M0i4FiitYXppj1uNO2/LZcYDuH8iqtWIFcdW+QRFw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RBzPw4EnRx2ZeZcOeKE2puS5vjXr5rTfFPXQff7vCUrYWMl8WyFKC+Oui3zpl1gvM uLon2HsEKtISPGmrkw/Qcu2cR7YICGPwQ0jiaM9agG31yXF525Rg4vdjcNxYEbV37N KG9s1Qd3cp4wLcKw/jJ4OE9KdogPTpCxAWNJTKOyVZxN/NfVERYy2GRRv6WFpb4kOV zHT7kBXphEmUsIsbzD3nqHeegZYqQ+qTsg4zb7B9JH9dpRpmQ5KiVlbc+cklBAVCCc 45/GLhAqeuHFih0aT8tdtynopIrPpJ3b58FKxZqfBjVxRLInhYzuWArDrPwM+BGW7K 4x7RzyJIO+fSQ== Original-Received: from alfajor (unknown [157.52.17.179]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B0B10120EE7; Fri, 5 Jun 2020 11:20:37 -0400 (EDT) In-Reply-To: <83y2p1a91g.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jun 2020 17:20:43 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/05 08:44:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251905 Archived-At: > Yes, it does. But the problem is more general, so the fix is not just > a kludge to fix what shr does. As the comment explains. Yes, the fix is fine. >> Isn't that a problem, since its docstring says: >>=20 >> [...] >> Setting this to nil is intended for use in debugging the display cod= e. >> [...] > > It's "do like I say, not like I do" ;-) ;-) >> Can we change SHR so it doesn't bind this var? > > I didn't see any better way at the time. Shr's na=EFve filling > algorithm cannot cope with the complexity of RTL text in an LTR > paragraph, when a long line has been continued. Maybe it's even > entirely impossible to DTRT in Lisp in these cases. But if you or > someone else have ideas, please describe them. Fair enough, thanks, Stefan