From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: A solution to display completion candidates after point in a minibuffer Date: Fri, 02 Oct 2020 20:10:46 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38366"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 03 02:11:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOV9I-0009ta-Fb for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Oct 2020 02:11:40 +0200 Original-Received: from localhost ([::1]:45470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOV9H-0007Kz-FQ for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Oct 2020 20:11:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOV8a-0006vl-VM for emacs-devel@gnu.org; Fri, 02 Oct 2020 20:10:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOV8Y-0003uO-Mg for emacs-devel@gnu.org; Fri, 02 Oct 2020 20:10:56 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1A2EE100275; Fri, 2 Oct 2020 20:10:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6CDC010023C; Fri, 2 Oct 2020 20:10:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1601683847; bh=QZ/ve2a98KHMDW1WDffFL8jhncTbLsKSnx/9LoBRag4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=j5a7vnaeKg0zhTJMogHDEVlSJGjwwXOq7QUtaWHKF6WKxyLmgr990vNOrU7s3g/Er aeLdvpmE7flDWkuq0ze2AfvltSM/+1HApgupqJgTkmZkDqsdVgHmskqqmZ/TJDcsX0 rfoIRPTjr2Ec2AVXviM2xXM4hcfKTEKEpsj+icqUnXdCsnjn+5RGgeKRJ49rtg1vbm fJSiGY3bOnHVi7FdccKadv/MLkL0iyX9CngGGJXZoQZ3EspAKmkhrdHnnGq+wXxGA4 D06WkWULiSnSd1Hs4uyIO8sZhCxCG/NmOmRjGmgchLqsXeiIiCHdyIE49cggMBhs/y P/KPWzpytfG4w== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 47A2B120439; Fri, 2 Oct 2020 20:10:47 -0400 (EDT) In-Reply-To: (Gregory Heytings's message of "Fri, 02 Oct 2020 23:11:22 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/02 18:44:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256980 Archived-At: >> [ FWIW, I just tried it in my local Emacs where I replaced the ad-hoc >> `resize_mini_window` scrolling with the use of `scroll-conservatively`, >> and I get the behavior that you seem to prefer. ] > Yes, that's not surprising, what your code does is essentially (or very > close to) what I suggested to do in bug#43519 and bug#43572, Not really, because with my code, the window start is not explicitly set to BOB unless the buffer's content is small enough to be completely visible (the first version of my patch did, but not the current one). > Thank you, now I see what you mean. IMO (and I would be extremely > surprised if I were the only one with that opinion) seeing the current > directory disappearing is disturbing (and from a newcomer point of > view: very disturbing), so the prompt an user input should always be > displayed (unless the miniwindow is too small of course). I agree it's suboptimal when entering the minibuffer. OTOH it's a perfectly acceptable behavior while editing the minibuffer's content and can even be preferable in some cases to what you propose. >> IIRC the reason it won't scroll the second time around is because point >> should be visible (and redisplay would only scroll in order to move point >> within view). > I don't know, but I'm not sure about that. If you (set-window-start nil 1) > unconditionally in window-scroll-functions, this setting will be obeyed by > redisplay, even if point is not visible anymore. Oh, indeed, in that case it would move point instead. Stefan