unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* cursor-intangible and rear-nonsticky t
@ 2021-04-05 15:26 JD Smith
  2021-04-05 16:47 ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: JD Smith @ 2021-04-05 15:26 UTC (permalink / raw)
  To: emacs-devel; +Cc: Stefan Monnier

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]


I’m trying to make a bit of leading text (the ` …: ` continued block prompt in python shell) skippable, so that cursor navigation passes right by without entering it.  I used 'intangible at first and it works well.  Noticing Stefan’s concerns about 'intangible, I tried to switch to 'cursor-intangible with `cursor-intangible-mode' enabled.  But I encountered some strange issues:

If '(rear-nonsticky t) is among the text properties, the `pre-redisplay-functions' do not apparently get called, and so 'cursor-intangible fails to function.  
On MacOS ports, enabling `cursor-intangible-mode' causes the frame to aggressively regrab focus and re-raise when it loses focus.  This makes it unusable.

I expect the latter is a bug, but perhaps the former is expected? Thanks.

[-- Attachment #2: Type: text/html, Size: 1224 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 15:26 cursor-intangible and rear-nonsticky t JD Smith
@ 2021-04-05 16:47 ` Stefan Monnier
  2021-04-05 16:56   ` Stefan Monnier
  2021-04-05 16:58   ` JD Smith
  0 siblings, 2 replies; 9+ messages in thread
From: Stefan Monnier @ 2021-04-05 16:47 UTC (permalink / raw)
  To: JD Smith; +Cc: emacs-devel

> If '(rear-nonsticky t) is among the text properties, the
> `pre-redisplay-functions' do not apparently get called, and so
> 'cursor-intangible fails to function.  

I don't think that's really what happens.  I suspect the issue comes
from the difference between `get-pos-property` and `get-char-property`:
positions (like `point`) are not placed on a character but between two
characters.  But text properties only apply to characters.  So the
properties that are "on a position" are based on what properties would
a character inherit if it where inserted at that position.

By default text properties are front-nonstick and rear-sticky, so
basically a position gets its properties from the char right before it.
But if you set (rear-nonsticky t), then you get no properties at all at
that position.

So, I suspect that you're applying (rear-nonsticky t) a bit too
generously, e.g. to all the chars in the prompt rather than only to the
last one.

> On MacOS ports, enabling `cursor-intangible-mode' causes the frame to
> aggressively regrab focus and re-raise when it loses focus.  This makes
> it unusable.

That's very weird and clearly a bug.


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 16:47 ` Stefan Monnier
@ 2021-04-05 16:56   ` Stefan Monnier
  2021-04-05 16:58   ` JD Smith
  1 sibling, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2021-04-05 16:56 UTC (permalink / raw)
  To: JD Smith; +Cc: emacs-devel

> So, I suspect that you're applying (rear-nonsticky t) a bit too
> generously, e.g. to all the chars in the prompt rather than only to the
> last one.

IIRC another way to do it is to only place the `cursor-intangible`
property between BEG and END-1, i.e. not on the last char of the prompt
and then you don't need any (rear-nonsticky t).


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 16:47 ` Stefan Monnier
  2021-04-05 16:56   ` Stefan Monnier
@ 2021-04-05 16:58   ` JD Smith
  2021-04-05 17:01     ` Stefan Monnier
  1 sibling, 1 reply; 9+ messages in thread
From: JD Smith @ 2021-04-05 16:58 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]



> On Apr 5, 2021, at 12:47 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> If '(rear-nonsticky t) is among the text properties, the
>> `pre-redisplay-functions' do not apparently get called, and so
>> 'cursor-intangible fails to function.  
> 
> I don't think that's really what happens.  I suspect the issue comes
> from the difference between `get-pos-property` and `get-char-property`:
> positions (like `point`) are not placed on a character but between two
> characters.  But text properties only apply to characters.  So the
> properties that are "on a position" are based on what properties would
> a character inherit if it where inserted at that position.
> 
> By default text properties are front-nonstick and rear-sticky, so
> basically a position gets its properties from the char right before it.
> But if you set (rear-nonsticky t), then you get no properties at all at
> that position.
> 
> So, I suspect that you're applying (rear-nonsticky t) a bit too
> generously, e.g. to all the chars in the prompt rather than only to the
> last one.

Interesting, so `rear-nonsticky t` is rather powerful in suppressing text-properties within contiguous text.  

I believe `comint-output-filter` is the one responsible for setting `rear-nonsticky t` across the entire prompt:

	    (let ((prompt-start (save-excursion (forward-line 0) (point)))
		  (inhibit-read-only t))
             ...
	      (add-text-properties prompt-start (point) '(rear-nonsticky t)))


[-- Attachment #2: Type: text/html, Size: 13198 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 16:58   ` JD Smith
@ 2021-04-05 17:01     ` Stefan Monnier
  2021-04-05 18:02       ` JD Smith
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2021-04-05 17:01 UTC (permalink / raw)
  To: JD Smith; +Cc: emacs-devel

> I believe `comint-output-filter` is the one responsible for setting
> `rear-nonsticky t` across the entire prompt:
>
> 	    (let ((prompt-start (save-excursion (forward-line 0) (point)))
> 		  (inhibit-read-only t))
>              ...
> 	      (add-text-properties prompt-start (point) '(rear-nonsticky t)))

That's unfortunate.  Deserves a bug report, methinks.


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 17:01     ` Stefan Monnier
@ 2021-04-05 18:02       ` JD Smith
  2021-04-05 18:47         ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: JD Smith @ 2021-04-05 18:02 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel



> On Apr 5, 2021, at 1:01 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> I believe `comint-output-filter` is the one responsible for setting
>> `rear-nonsticky t` across the entire prompt:
>> 
>> 	    (let ((prompt-start (save-excursion (forward-line 0) (point)))
>> 		  (inhibit-read-only t))
>>             ...
>> 	      (add-text-properties prompt-start (point) '(rear-nonsticky t)))
> 
> That's unfortunate.  Deserves a bug report, methinks.


Will do.  Between that and the focus-grabbing on MacOS ports, plain old ‘intangible is looking better and better.  It also doesn’t seem to care about over-generous application of ‘rear-nonsticky t. 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 18:02       ` JD Smith
@ 2021-04-05 18:47         ` Stefan Monnier
  2021-04-05 21:11           ` JD Smith
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2021-04-05 18:47 UTC (permalink / raw)
  To: JD Smith; +Cc: emacs-devel

>>> I believe `comint-output-filter` is the one responsible for setting
>>> `rear-nonsticky t` across the entire prompt:
>>> 
>>> 	    (let ((prompt-start (save-excursion (forward-line 0) (point)))
>>> 		  (inhibit-read-only t))
>>>             ...
>>> 	      (add-text-properties prompt-start (point) '(rear-nonsticky t)))
>> 
>> That's unfortunate.  Deserves a bug report, methinks.
>
> Will do.  Between that and the focus-grabbing on MacOS ports, plain old
> ‘intangible is looking better and better.

The problem above is easy to workaround until the problem is fixed
upstream (by overriding comint's `rear-nonsticky` property with your
own).  For the MacOS issue, I have no idea: maybe it'll be difficult to
workaround, or maybe it's specific to unusual setups (really, I'm at
pains to imagine how `cursor-intangible-mode` can cause the problems you
describe, so I'd tend to suspect an interaction with some wild-west
package doing dangerous things).

> It also doesn’t seem to care about over-generous application of
> ‘rear-nonsticky t. 

It has its share of brokenness, don't worry ;-)


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 18:47         ` Stefan Monnier
@ 2021-04-05 21:11           ` JD Smith
  2021-04-05 21:30             ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: JD Smith @ 2021-04-05 21:11 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]



> On Apr 5, 2021, at 2:47 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
> The problem above is easy to workaround until the problem is fixed
> upstream


Yes a simple ‘(cursor-intangible t rear-nonsticky nil) seems to do it. 

> I'd tend to suspect an interaction with some wild-west
> package doing dangerous things)

Your suspicions are well-calibrated.  I haven’t yet figured out the culprit, but it was a package interaction issue. 

[-- Attachment #2: Type: text/html, Size: 2381 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: cursor-intangible and rear-nonsticky t
  2021-04-05 21:11           ` JD Smith
@ 2021-04-05 21:30             ` Stefan Monnier
  0 siblings, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2021-04-05 21:30 UTC (permalink / raw)
  To: JD Smith; +Cc: emacs-devel

>> The problem above is easy to workaround until the problem is fixed
>> upstream
> Yes a simple ‘(cursor-intangible t rear-nonsticky nil) seems to do it. 

You might want to be more considerate of comint and preserve the
nonstickiness behavior for the properties that it places, e.g. something
like:

    (cursor-intangible t rear-nonsticky (field read-only inhibit-line-move-field-capture))

[ This value of `rear-nonsticky` is the I used in the patch I just
  installed into `master`.  ]

>> I'd tend to suspect an interaction with some wild-west
>> package doing dangerous things)
> Your suspicions are well-calibrated.  I haven’t yet figured out the culprit,
> but it was a package interaction issue.

Even if it doesn't end up with a bug report in Emacs, I'd be interested
to know what was the culprit and how it ended up behaving that way.


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-04-05 21:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 15:26 cursor-intangible and rear-nonsticky t JD Smith
2021-04-05 16:47 ` Stefan Monnier
2021-04-05 16:56   ` Stefan Monnier
2021-04-05 16:58   ` JD Smith
2021-04-05 17:01     ` Stefan Monnier
2021-04-05 18:02       ` JD Smith
2021-04-05 18:47         ` Stefan Monnier
2021-04-05 21:11           ` JD Smith
2021-04-05 21:30             ` Stefan Monnier

unofficial mirror of emacs-devel@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/emacs-devel/0 emacs-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 emacs-devel emacs-devel/ https://yhetil.org/emacs-devel \
		emacs-devel@gnu.org
	public-inbox-index emacs-devel

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.devel
	nntp://news.gmane.io/gmane.emacs.devel


code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git