From: Stefan Monnier <monnier@iro.umontreal.ca>
To: akater <nuclearspace@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Add cl-map-into
Date: Mon, 27 Sep 2021 13:18:09 -0400 [thread overview]
Message-ID: <jwvee9at0bn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87h7eag90n.fsf@gmail.com> (akater's message of "Thu, 23 Sep 2021 23:35:52 +0000")
> Absense of Common Lisp's map-into in cl-lib is an unfortunate omission.
[ As someone who likes to avoid side-effects, I have a slightly different
opinion ;-) ]
> The proposed patch adds it.
Looks pretty good. I have a code suggestion below, but my main
comments would be:
- Could you provide some corresponding tests for test/emacs-lisp/cl-tests.el?
- Since we're (weakly) promoting seq.el over cl-lib.el, I wonder if you
think it would be worthwhile to try and do something similar in seq.el?
> + (or (and small basic-cache)
> + (and (not small) general-cache)
> + (let ((mapper (cl--make-map-into-mapper sig)))
> + (if small (setf basic-cache mapper)
> + (setf general-cache mapper))))))
This can turn into
(or (if small basic-cache general-cache)
(let ((mapper (cl--make-map-into-mapper sig)))
(setf (if small basic-cache general-cache)
mapper)))
AKA
(or (if small basic-cache general-cache)
(setf (if small basic-cache general-cache)
(cl--make-map-into-mapper sig)))
which thus looks very much like what I used in
`cl--generic-with-memoization`, so you could replace the symbol-macrolet
with something like:
(cl--generic-with-memoization
(if small
(aref cl--map-into-mappers-array sig)
;; TODO: Order alist entries for faster lookup
;; (note that we'll have to abandon alist-get then).
(alist-get sig cl--map-into-mappers-alist nil nil #'=))
(cl--make-map-into-mapper sig))
-- Stefan
next prev parent reply other threads:[~2021-09-27 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 23:35 [PATCH] Add cl-map-into akater
2021-09-27 17:18 ` Stefan Monnier [this message]
2021-09-29 19:30 ` akater
2021-09-29 20:26 ` Stefan Monnier
2021-09-30 6:38 ` Bozhidar Batsov
2021-09-30 13:03 ` Adam Porter
2021-09-30 13:09 ` Bozhidar Batsov
2021-09-30 13:21 ` Adam Porter
2021-09-30 15:00 ` akater
2021-10-01 18:40 ` Stefan Monnier
2021-10-01 18:51 ` Eli Zaretskii
2021-10-01 19:04 ` Tassilo Horn
2021-10-01 20:52 ` Stefan Monnier
2021-10-01 22:08 ` Glenn Morris
2021-10-02 3:53 ` Stefan Monnier
2021-10-06 23:35 ` [PATCH] Add cl-map-into, revision 2 akater
2021-10-07 7:18 ` Eli Zaretskii
2021-10-07 8:24 ` akater
2021-10-07 9:00 ` Eli Zaretskii
2021-10-09 2:46 ` [PATCH] Add cl-map-into, revision 3 akater
2021-10-13 22:32 ` Stefan Monnier
2021-10-26 12:52 ` akater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvee9at0bn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=nuclearspace@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).