From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Alexander Adolf <alexander.adolf@condition-alpha.com>
Subject: Re: master 620ac67355: EUDC: Add completion-at-point support
Date: Tue, 10 May 2022 18:06:33 -0400 [thread overview]
Message-ID: <jwvee11oxrz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220510211208.6A954C01683@vcs2.savannah.gnu.org> (Thomas Fitzsimmons's message of "Tue, 10 May 2022 17:12:08 -0400 (EDT)")
> +;; The first mechanism is intended for use by the modes listed in
> +;; `eudc-capf-modes', and relies on these modes adding
> +;; `eudc-capf-complete' to `completion-at-point-functions', as
> +;; would be usually done for any general-purpose completion
> +;; function. In this mode of operation, and in order to offer
> +;; email addresses only in contexts where the user would expect
> +;; them, a check is performed whether point is on a line that is a
> +;; message header field suitable for email addresses, such as for
> +;; example "To:", "Cc:", etc.
> +;;
> +;; The second mechanism is intended for when the user modifies
> +;; `message-completion-alist' to replace `message-expand-name' with
> +;; the function `eudc-capf-message-expand-name'. As a result,
> +;; minibuffer completion (`completing-read') for email addresses
> +;; would no longer enabled in `message-mode', but
> +;; `completion-at-point' (in-buffer completion) only.
Could you contrast the behavior of this new code with the one we get
from `message--name-table` (i.e. when setting
`message-expand-name-standard-ui`)?
Looking at the code in message.el it seems it should provide a fairly
similar behavior. It seems to do similar caching, uses
(eudc-query-with-words (split-string orig-string "[ \t]+")) like your
code, tho your code passes an extra t arg to "try-all-servers".
Maybe message.el should also use that?
Any other difference?
Stefan
next parent reply other threads:[~2022-05-10 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165221712797.22071.2062685793306083928@vcs2.savannah.gnu.org>
[not found] ` <20220510211208.6A954C01683@vcs2.savannah.gnu.org>
2022-05-10 22:06 ` Stefan Monnier [this message]
2022-05-16 13:12 ` master 620ac67355: EUDC: Add completion-at-point support Alexander Adolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvee11oxrz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=alexander.adolf@condition-alpha.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).