From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Integrate my package into Emacs Date: Tue, 24 May 2022 19:11:54 -0400 Message-ID: References: <3a9397d6-7d11-f9f7-bcf6-03ccfa83e67f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36750"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mariano Montone Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 25 01:19:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntdoe-0009Mw-C6 for ged-emacs-devel@m.gmane-mx.org; Wed, 25 May 2022 01:19:52 +0200 Original-Received: from localhost ([::1]:51890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntdod-0008Ah-Ew for ged-emacs-devel@m.gmane-mx.org; Tue, 24 May 2022 19:19:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntdh8-00068z-0F for emacs-devel@gnu.org; Tue, 24 May 2022 19:12:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntdh5-0007k9-0n for emacs-devel@gnu.org; Tue, 24 May 2022 19:12:04 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 894178007C; Tue, 24 May 2022 19:12:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0DA18803DC; Tue, 24 May 2022 19:11:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1653433916; bh=mA5nhuonBQXbix44YGEuOFkadfkigidm602DyoidIgE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ak+x2xrL4VugSpU07FKNf8GLGdNrfOE1HE6zstsf/innTG/CEmy7qi+IIGACT5++t X+hz8k3wKySESaHAnVSTWCsk5Af61yGFLqEs737nSWc/fxFKORQO98cTcRXSmn7d39 kCkM2ReMDp8CSEdh2OPo/KEfZf1ca7m4ToRyGhuB/ybGrBR0ELCMCZSjPJkov+PHO+ Xc4D1uSnm027rQaByXSUX0mIYIlMnIt1eUbpM+8SBUdMfwcnEon14xoU6p2v2Od5je 68DwHXr5iJrUe78WqXC57e6ex4MZ03OIyBnzI23/GhZl4/nrxSTX4Si7DIcXMDqgdB +a2BkAZUSUziQ== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D4C67120185; Tue, 24 May 2022 19:11:55 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Tue, 24 May 2022 18:59:05 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290221 Archived-At: > See patch below which includes the copyright change along with various > FIXME comments (meant to be read rather than applied. If you have any > questions/answers about those FIXMEs, feel free to send them right here). One more comment: it would be good to expand the docstring of `cl-defgeneric inspect-object` to clarify what is expected from methods of this generic function. E.g. specify that they're supposed to write into the current-buffer, clarify if that buffer can be presumed to be empty or not and what kind of formatting it can/should obey (e.g. mention that they're expected to use `inspector--insert-inspect-button` when inserting a sub-object). Also, I'm curious why you used a default method for that generic function where you have a big `cond` dispatching on the type of the argument: why not use separate methods instead? Stefan