From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master afc0bfd380: Speed up loaddefs-generate on slow disks Date: Thu, 02 Jun 2022 11:10:32 -0400 Message-ID: References: <165416120601.23485.9799765950267646757@vcs2.savannah.gnu.org> <20220602091326.514E9C009A8@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 02 17:12:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwmUi-000ART-Vc for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jun 2022 17:12:17 +0200 Original-Received: from localhost ([::1]:40148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwmUh-0006JL-P1 for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jun 2022 11:12:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwmTC-0005WT-3Z for emacs-devel@gnu.org; Thu, 02 Jun 2022 11:10:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17891) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwmT8-0004cx-TV for emacs-devel@gnu.org; Thu, 02 Jun 2022 11:10:40 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 79C4A80781; Thu, 2 Jun 2022 11:10:36 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1EB488045E; Thu, 2 Jun 2022 11:10:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654182635; bh=tSLmbY9TrSYpTK+BT7pxSq757BN+1J28Ygd+kfklBjI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MIRthOGDvUHBweI3Q7KCxa5RY1hKbq3AdeMBotoAj6rBj4UNI6XSEe8xgGvOWo6IM 7pjgLUKxoOBvpLMZL8cZzsxSrT2zyN/vlHYBZ+SaqHKuiCads8ereoGtIr4C71zOl4 lgjce6Rw5UYp7/PXvr+5tpWLI63In2XFnvUhTDzW1E+qIfffDaJqiZ5wvl0bsr0njH ZODVtpIfQpuPLvKgi1QBOh/r9VGpzjag7u66P4yJe1TwsqYafmPUfsw1LdtJouYLN9 GdSGl6haGxnK1CgXnjBXLCY9iWpLkSylrTCgRpT3VMTNVF22E0Sp6SRutXECzKJIHI s/TbXJavVjFUw== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DD16A120204; Thu, 2 Jun 2022 11:10:34 -0400 (EDT) In-Reply-To: <20220602091326.514E9C009A8@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Thu, 2 Jun 2022 05:13:26 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290566 Archived-At: > Speed up loaddefs-generate on slow disks [...] > @@ -522,11 +522,15 @@ If INCLUDE-PACKAGE-VERSION, include package version data." > (byte-compile-info > (concat "Scraping files for loaddefs")) > 0 (length files) nil 10)) > + (output-time > + (file-attribute-modification-time (file-attributes output-file))) > (file-count 0)) > (dolist (file files) > (progress-reporter-update progress (setq file-count (1+ file-count))) > (when (or (not updating) > - (file-newer-than-file-p file output-file)) > + (time-less-p output-time > + (file-attribute-modification-time > + (file-attributes file)))) > (setq defs (nconc > (loaddefs-generate--parse-file > file output-file I'm really surprised this is faster, even on slow disks. Does anyone have a idea of why that is? Maybe `file-newer-than-file-p` should accept a time value for one of the two file names so we can speed this up further by refraining from constructing a whole `file-attributes` only to reduce it down to a single boolean? Stefan