From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: auto-save-visited-file-name Date: 17 Oct 2003 17:14:59 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1066426618 18936 80.91.224.253 (17 Oct 2003 21:36:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 17 Oct 2003 21:36:58 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Oct 17 23:36:55 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AAcHH-0000Cv-00 for ; Fri, 17 Oct 2003 23:36:55 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AAcHF-0000l9-00 for ; Fri, 17 Oct 2003 23:36:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AAcDe-00032j-A4 for emacs-devel@quimby.gnus.org; Fri, 17 Oct 2003 17:33:10 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AAc8Z-0006EY-6u for emacs-devel@gnu.org; Fri, 17 Oct 2003 17:27:55 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AAc7y-0005Jx-Hg for emacs-devel@gnu.org; Fri, 17 Oct 2003 17:27:50 -0400 Original-Received: from [199.232.41.8] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.24) id 1AAc7F-0004bx-Dp; Fri, 17 Oct 2003 17:26:33 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by mx20.gnu.org with esmtp (Exim 4.24) id 1AAbwD-0007g7-Ib; Fri, 17 Oct 2003 17:15:09 -0400 Original-Received: from vor.iro.umontreal.ca (vor.iro.umontreal.ca [132.204.24.42]) by mercure.iro.umontreal.ca (8.12.9/8.12.9) with ESMTP id h9HLF1UN028917; Fri, 17 Oct 2003 17:15:01 -0400 Original-Received: by vor.iro.umontreal.ca (Postfix, from userid 20848) id 0ADE13C63E; Fri, 17 Oct 2003 17:15:01 -0400 (EDT) Original-To: rms@gnu.org In-Reply-To: Original-Lines: 32 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner: Found to be clean X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17229 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17229 > Does this solve the problems you found with auto-save-visited-file-name? It helps, but see below. > *** buffer.c.~1.438.~ Thu Sep 11 09:51:05 2003 > --- buffer.c Fri Oct 17 11:37:36 2003 > *************** > *** 1429,1435 **** > if (STRINGP (b->auto_save_file_name) > && b->auto_save_modified != 0 > && BUF_SAVE_MODIFF (b) < b->auto_save_modified > ! && BUF_SAVE_MODIFF (b) < BUF_MODIFF (b)) > { > Lisp_Object tem; > tem = Fsymbol_value (intern ("delete-auto-save-files")); > --- 1429,1436 ---- > if (STRINGP (b->auto_save_file_name) > && b->auto_save_modified != 0 > && BUF_SAVE_MODIFF (b) < b->auto_save_modified > ! && BUF_SAVE_MODIFF (b) < BUF_MODIFF (b) > ! && NILP (Fsymbol_value (intern ("auto-save-visited-file-name")))) > { > Lisp_Object tem; > tem = Fsymbol_value (intern ("delete-auto-save-files")); I think the above has a problem: auto-save-visited-file-name is only consulted when setting up buffer-auto-save-file-name, so it can have a value inconsistent with the actual situation. Better check whether buffer-auto-save-file-name is equal to buffer-file-name. Stefan