* Problem report #24
@ 2006-04-10 18:50 Dan Nicolaescu
2006-04-10 19:00 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2006-04-10 18:50 UTC (permalink / raw
CID: 24
Checker: FORWARD_NULL (help)
File: emacs/src/xfaces.c
Function: Fx_list_fonts
Description: Variable "f" tracked as NULL was passed to a function that dereferences it.
Event assign_zero: Variable "f" assigned value 0.
Also see events: [var_deref_model]
3022 f = NULL;
3023 face = Qnil;
3024 }
3025
3026 /* Determine the width standard for comparison with the fonts we find. */
3027
At conditional (1): "face == Qnil" taking false path
3028 if (NILP (face))
3029 size = 0;
3030 else
3031 {
3032 /* This is of limited utility since it works with character
3033 widths. Keep it for compatibility. --gerd. */
Event var_deref_model: Variable "f" tracked as NULL was passed to a function that dereferences it. [model]
Also see events: [assign_zero]
3034 int face_id = lookup_named_face (f, face, 0, 0);
3035 struct face *face = (face_id < 0
3036 ? NULL
3037 : FACE_FROM_ID (f, face_id));
3038
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Problem report #24
2006-04-10 18:50 Problem report #24 Dan Nicolaescu
@ 2006-04-10 19:00 ` Stefan Monnier
2006-04-11 7:00 ` Jan D.
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2006-04-10 19:00 UTC (permalink / raw
> Event assign_zero: Variable "f" assigned value 0.
> Also see events: [var_deref_model]
> 3022 f = NULL;
> 3023 face = Qnil;
> 3024 }
> 3025
> 3026 /* Determine the width standard for comparison with the fonts we find. */
> 3027
> At conditional (1): "face == Qnil" taking false path
> 3028 if (NILP (face))
> 3029 size = 0;
> 3030 else
> 3031 {
> 3032 /* This is of limited utility since it works with character
> 3033 widths. Keep it for compatibility. --gerd. */
> Event var_deref_model: Variable "f" tracked as NULL was passed to a function that dereferences it. [model]
> Also see events: [assign_zero]
If f is NULL, then face=Qnil, so the false path of face==Qnil won't
be taken.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Problem report #24
2006-04-10 19:00 ` Stefan Monnier
@ 2006-04-11 7:00 ` Jan D.
2006-04-11 14:29 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Jan D. @ 2006-04-11 7:00 UTC (permalink / raw
Cc: emacs-devel
Stefan Monnier wrote:
>> Event assign_zero: Variable "f" assigned value 0.
>> Also see events: [var_deref_model]
>
>> 3022 f = NULL;
>> 3023 face = Qnil;
>> 3024 }
>> 3025
>> 3026 /* Determine the width standard for comparison with the fonts we find. */
>> 3027
>
>> At conditional (1): "face == Qnil" taking false path
>
>> 3028 if (NILP (face))
>> 3029 size = 0;
>> 3030 else
>> 3031 {
>> 3032 /* This is of limited utility since it works with character
>> 3033 widths. Keep it for compatibility. --gerd. */
>
>> Event var_deref_model: Variable "f" tracked as NULL was passed to a function that dereferences it. [model]
>> Also see events: [assign_zero]
>
> If f is NULL, then face=Qnil, so the false path of face==Qnil won't
> be taken.
>
face could be Qnil upon entry to the function?
Jan D.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Problem report #24
2006-04-11 7:00 ` Jan D.
@ 2006-04-11 14:29 ` Stefan Monnier
2006-04-12 2:20 ` Richard Stallman
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2006-04-11 14:29 UTC (permalink / raw
Cc: emacs-devel
>>> Event assign_zero: Variable "f" assigned value 0.
>>> Also see events: [var_deref_model]
>>
>>> 3022 f = NULL;
>>> 3023 face = Qnil;
>>> 3024 }
>>> 3025
>>> 3026 /* Determine the width standard for comparison with the fonts we find. */
>>> 3027
>>
>>> At conditional (1): "face == Qnil" taking false path
>>
>>> 3028 if (NILP (face))
>>> 3029 size = 0;
>>> 3030 else
>>> 3031 {
>>> 3032 /* This is of limited utility since it works with character
>>> 3033 widths. Keep it for compatibility. --gerd. */
>>
>>> Event var_deref_model: Variable "f" tracked as NULL was passed to a function that dereferences it. [model]
>>> Also see events: [assign_zero]
>> If f is NULL, then face=Qnil, so the false path of face==Qnil won't
>> be taken.
>>
> face could be Qnil upon entry to the function?
Sure, no problem: the problem report is when f==NULL and face!=Qnil.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-04-12 3:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-10 18:50 Problem report #24 Dan Nicolaescu
2006-04-10 19:00 ` Stefan Monnier
2006-04-11 7:00 ` Jan D.
2006-04-11 14:29 ` Stefan Monnier
2006-04-12 2:20 ` Richard Stallman
2006-04-12 3:39 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).