Indentation of LISP code

Indentation of LISP code

[A Soare]

Because it was proved that the indentation in lisp mode must be rewritten ( project for after the release ) I would like to ask your opinion about this situation:

Do you prefer that the line 

( defun  ( x &optional a b  c d)

after applying an indent-function

stay in the same form, or to be rendered so:

(defun (x &optional a b c d)


I would like to know your opinions about.

Thank you.

Alin Soare

Re: Indentation of LISP code

[Miles Bader]

A Soare <alinsoar@voila.fr> writes:
> ( defun  ( x &optional a b  c d)
> after applying an indent-function
> stay in the same form, or to be rendered so:
> (defun (x &optional a b c d)

Removing whitespace around parentheses doesn't sound like indentation to
me...

-miles

-- 
Quidquid latine dictum sit, altum viditur.

Re: Indentation of LISP code

[Stuart D. Herring]

> Do you prefer that the line
>
> ( defun  ( x &optional a b  c d)
>
> after applying an indent-function
>
> stay in the same form, or to be rendered so:
>
> (defun (x &optional a b c d)

Indentation never changes whitespace within a line except (sometimes) to
adjust the space between the end of the real code and any comment on the
line.  I can't see a reason that we would want to change that, and only
for Lisp.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: Indentation of LISP code

[A Soare]

> Removing whitespace around parentheses doesn't sound like indentation to
> me...


In this moment some spaces are added sometimes

();test

Indent it using TAB then select and indent it with C-M-\

Re: Indentation of LISP code

[Miles Bader]

A Soare <alinsoar@voila.fr> writes:
>> Removing whitespace around parentheses doesn't sound like indentation to
>> me...
>
> In this moment some spaces are added sometimes
>
> ();test

That is indentation:  it indents both the code and the comment, each of
which has a fixed column that it should start in.

-miles
-- 
o The existentialist, not having a pillow, goes everywhere with the book by
  Sullivan, _I am going to spit on your graves_.

Re: Indentation of LISP code

[Richard Stallman]

    Do you prefer that the line 

    ( defun  ( x &optional a b  c d)

    after applying an indent-function

    stay in the same form,

Yes.

			   or to be rendered so:

    (defun (x &optional a b c d)

Definitely not.  Indentation commands should not alter whitespace
within the code.  They should change the indentation of code and
comments, but not internal whitespace.

Re: Indentation of LISP code

[A Soare]

In this moment one ignores the indentation of commented lines with ;;; like this one:

;;; this is a commented line.

However:

(defun lisp-indent-region (start end)
  "Indent every line whose first char is between START and END inclusive."
  (save-excursion
    (asa;;;a     <=<= THIS LINE IS NOT IGNORED, IT IS TREATED AS DOUBLE COMMENTED
     ))

  )

(USE INDENT REGION TO INDENT)

In future (after the release) this indentation should be ignored too or treated as double commented ;;?

alin soare.

Re: Indentation of LISP code

[Stefan Monnier]

> In this moment one ignores the indentation of commented lines with ;;;
> like this one: ;;; this is a commented line.

> However:

> (defun lisp-indent-region (start end)
>   "Indent every line whose first char is between START and END inclusive."
>   (save-excursion
>     (asa;;;a     <=<= THIS LINE IS NOT IGNORED, IT IS TREATED AS DOUBLE COMMENTED
>      ))

>   )

> (USE INDENT REGION TO INDENT)

> In future (after the release) this indentation should be ignored too or
> treated as double commented ;;?

I don't understand the problem.  The only difference I can see is that
a space gets added before ";;;".  Lisp's indent-region does both re-indent
the code and the comments, so it's completely expected behavior.


        Stefan

Re: Indentation of LISP code

[A Soare]

> I don't understand the problem.  The only difference I can see is that
> a space gets added before ";;;".  Lisp's indent-region does both re-indent
> the code and the comments, so it's completely expected behavior.


Put instead ;;; just 2 comments then just 1.

You will see that using ;;; is the same case as with ;;.

When we put ;;; the indent of the comment must not change, so

(nil);;; this is a comm

must not change.

A Soare.

Re: Indentation of LISP code

[Stefan Monnier]

> When we put ;;; the indent of the comment must not change.

And who said so?
AFAIK, the only rule about ";;;" is that they should be "indented" to
column 0, which in the present case is impossible.


        Stefan

Re: Indentation of LISP code

[A Soare]

> > When we put ;;; the indent of the comment must not change.
> 
> And who said so?
> AFAIK, the only rule about ";;;" is that they should be "indented" to
> column 0, which in the present case is impossible.


Hoops ! I do not know. Will somebody explain me how do you want these comments to show in future? (example and explanations with all line commented and also ;;; comment at the end of the line).

Thanks!

Re: Indentation of LISP code

[Thien-Thi Nguyen]

() A Soare <alinsoar@voila.fr>
() Fri,  6 Apr 2007 10:20:28 +0200 (CEST)

   > AFAIK, the only rule about ";;;" is that they should be "indented"
   > to column 0, which in the present case is impossible.

   Will somebody explain me how do you want these comments to show in
   future? (example and explanations with all line commented and also
   ;;; comment at the end of the line).

perhaps this will suffice: (info "(elisp)Comment Tips")

thi

Re: Indentation of LISP code

[A Soare]

>    > AFAIK, the only rule about ";;;" is that they should be "indented"
>    > to column 0, which in the present case is impossible.
> 
>    Will somebody explain me how do you want these comments to show in
>    future? (example and explanations with all line commented and also
>    ;;; comment at the end of the line).
> 
> perhaps this will suffice: (info "(elisp)Comment Tips")


Thanks. I will use the defs. from that section of elisp manual to indent.

Re: Indentation of LISP code

[Stefan Monnier]

>> > When we put ;;; the indent of the comment must not change.
>> And who said so?
>> AFAIK, the only rule about ";;;" is that they should be "indented" to
>> column 0, which in the present case is impossible.

> Hoops ! I do not know. Will somebody explain me how do you want these
> comments to show in future? (example and explanations with all line
> commented and also ;;; comment at the end of the line).

The rule when doing a rewrite generally goes as follows:
- when in doubt, preserve the old behavior.
And in most cases you also have to apply this other rules:
- even in the absence of a doubt, make sure the user can still get the
  old behavior.
Oh, and here's another important one:
- any change you introduce without even thinking about it, will invariably
  lead to objections.


        Stefan