From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: toggling diff-auto-refine Date: Tue, 01 Jan 2008 21:37:22 -0500 Message-ID: References: <87prwpr42e.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199241452 12840 80.91.229.12 (2 Jan 2008 02:37:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Jan 2008 02:37:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 02 03:37:52 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J9tUM-0003hy-8c for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2008 03:37:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9tU0-0006Zi-ET for ged-emacs-devel@m.gmane.org; Tue, 01 Jan 2008 21:37:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J9tTx-0006ZQ-0z for emacs-devel@gnu.org; Tue, 01 Jan 2008 21:37:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J9tTv-0006ZA-K3 for emacs-devel@gnu.org; Tue, 01 Jan 2008 21:37:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9tTv-0006Z7-DJ for emacs-devel@gnu.org; Tue, 01 Jan 2008 21:37:23 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J9tTv-0000px-2t for emacs-devel@gnu.org; Tue, 01 Jan 2008 21:37:23 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAOWHekfO+IaddGdsb2JhbACQEQEwlXQ X-IronPort-AV: E=Sophos;i="4.24,231,1196658000"; d="scan'208";a="12171914" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 01 Jan 2008 21:37:22 -0500 Original-Received: from pastel.home ([206.248.134.157]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id IDN75022; Tue, 01 Jan 2008 21:37:22 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 6E55F84AE; Tue, 1 Jan 2008 21:37:21 -0500 (EST) In-Reply-To: <87prwpr42e.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Sat, 29 Dec 2007 15:03:21 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85842 Archived-At: > how about replacing the `(defcustom diff-auto-refine ...)' with: > (define-minor-mode diff-auto-refine > "Automatically highlight changes in detail as the user visits hunks." > :group 'diff-mode :init-value nil :lighter " Auto-Refine" > (when diff-auto-refine > (condition-case-no-debug nil (diff-refine-hunk) (error nil)))) Fine by me, but: - please call it "-mode" then. - not sure if the merged mode for smerge+diff should use the "diff" prefix. After all, the actual main code is in the smerge-mode.el file, so maybe the "smerge-" prefix would be more consistent. Then again, moving this code out of smerge to some shared place might be even better. Stefan