From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thien-Thi Nguyen <ttn@gnuvola.org>
Cc: emacs-devel@gnu.org
Subject: Re: toggling diff-auto-refine
Date: Tue, 01 Jan 2008 21:37:22 -0500 [thread overview]
Message-ID: <jwvd4slarab.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87prwpr42e.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Sat, 29 Dec 2007 15:03:21 +0100")
> how about replacing the `(defcustom diff-auto-refine ...)' with:
> (define-minor-mode diff-auto-refine
> "Automatically highlight changes in detail as the user visits hunks."
> :group 'diff-mode :init-value nil :lighter " Auto-Refine"
> (when diff-auto-refine
> (condition-case-no-debug nil (diff-refine-hunk) (error nil))))
Fine by me, but:
- please call it "-mode" then.
- not sure if the merged mode for smerge+diff should use the
"diff" prefix. After all, the actual main code is in the
smerge-mode.el file, so maybe the "smerge-" prefix would be
more consistent. Then again, moving this code out of smerge to some
shared place might be even better.
Stefan
prev parent reply other threads:[~2008-01-02 2:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 14:03 toggling diff-auto-refine Thien-Thi Nguyen
2007-12-30 17:03 ` Thien-Thi Nguyen
2008-01-02 2:37 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd4slarab.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=ttn@gnuvola.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).