Re: Maintenance suggestion on an emacs mode

[Stefan Monnier <monnier@IRO.UMontreal.CA>]

> Please apply the following patch to vhdl-mode.el:

The patch was line-wrapped and failed.  Also please use (unified)
context diffs when sending patches.  And of course, please include
a ChangeLog entry along with the patch.  Thank you,


        Stefan


> 2726,2731c2726,2731
> <   (define-key vhdl-mode-map "\C-c\C-c\C-n" 'vhdl-compose-new-component)
> <   (define-key vhdl-mode-map "\C-c\C-c\C-p" 'vhdl-compose-place-component)
> <   (define-key vhdl-mode-map "\C-c\C-c\C-w" 'vhdl-compose-wire-components)
> <   (define-key vhdl-mode-map "\C-c\C-c\C-f" 'vhdl-compose-configuration)
> <   (define-key vhdl-mode-map "\C-c\C-c\C-k"
> vhdl-compose-components-package)
> <   (define-key vhdl-mode-map "\C-cc"       'vhdl-comment-uncomment-region)
> ---
>> (define-key vhdl-mode-map "\C-c\C-m\C-n" 'vhdl-compose-new-component)
>> (define-key vhdl-mode-map "\C-c\C-m\C-p" 'vhdl-compose-place-component)
>> (define-key vhdl-mode-map "\C-c\C-m\C-w" 'vhdl-compose-wire-components)
>> (define-key vhdl-mode-map "\C-c\C-m\C-f" 'vhdl-compose-configuration)
>> (define-key vhdl-mode-map "\C-c\C-m\C-k" 
> 'vhdl-compose-components-package)
>> (define-key vhdl-mode-map "\C-c\C-c" 
> 'vhdl-comment-uncomment-region)
> 2770,2771c2770,2771
> <   (define-key vhdl-mode-map "\C-cf"       'vhdl-fontify-buffer)
> <   (define-key vhdl-mode-map "\C-cs"       'vhdl-statistics-buffer)
> ---
>> (define-key vhdl-mode-map "\C-c\C-i\C-f" 'vhdl-fontify-buffer)
>> (define-key vhdl-mode-map "\C-c\C-i\C-s" 'vhdl-statistics-buffer)

> Reto


> paul r wrote:

>> Hello,
>> 
>> You are contacted because you are mentioned as the maintainer of a
>> mode now included in GNU Emacs, development version 23 as of today, on
>> which we suggest you to do some small modifications.
>> Those modifications concern some default key bindings on your mode
>> map, bound on the C-c[a-zA-Z] pattern, which is supposed to be
>> reserved for users, as explained in the last paragraph of the link
>> [1].
>> Each of you will receive an other email with the file to fix and the
>> matching lines. If possible, please send back a patch on emacs-devel
>> with those keybindings changed.
>> Thank you
>> 
>> -- Paul
>> 
>> [1] http://www.gnu.org/software/emacs/manual/html_node/emacs/Keymaps.html