From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Faces applies to new frames
Date: Thu, 26 Jun 2008 21:28:48 -0400 [thread overview]
Message-ID: <jwvd4m3fzd3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k5gbx12n.fsf@stupidchicken.com> (Chong Yidong's message of "Thu, 26 Jun 2008 18:50:56 -0400")
> AFAICT, the problem is that the default face is controlled by the `font'
> frame parameter, but this is not saved to default-frame-alist by
> internal-set-lisp-face-attribute. In comparison, the foreground-color
I'm not convinced this is the root of the problem. For one, by default
there is no `font' parameter in default-frame-alist, so as long as we
leave it that way, it should not affect face settings. The code in
face-set-after-frame-default should apply the defface-spec to every
new frame, so we shouldn't need any entry in default-frame-alist for it
to apply to new frames. The face-set-after-frame-default used to skip
`default', so that was an important reason for the bug#47. I've fixed
this part, but there are other weird things going on (I have some other
weird problems here where X resources are obeyed even after I remove
the calls to `make-face-x-resource-internal').
I think we need to write down every step of how faces are initialized
for each frame (then lament the fact faces are the same on all frames in
99.99% of the cases), then how frame-parameters are treated, and then
how they affect each other.
Stefan
next prev parent reply other threads:[~2008-06-27 1:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 22:50 Faces applies to new frames Chong Yidong
2008-06-26 23:08 ` Miles Bader
2008-06-27 1:28 ` Stefan Monnier [this message]
2008-06-27 2:43 ` Chong Yidong
2008-06-27 6:18 ` Stefan Monnier
2008-06-27 17:32 ` Chong Yidong
2008-06-27 17:52 ` Stefan Monnier
2008-06-27 17:54 ` Chong Yidong
2008-06-27 10:48 ` Robert J. Chassell
2008-06-27 12:17 ` Robert J. Chassell
2008-06-28 16:01 ` Chong Yidong
2008-06-28 20:17 ` Stefan Monnier
2008-06-28 23:42 ` Chong Yidong
2008-06-29 3:14 ` Stefan Monnier
2008-06-29 3:42 ` Miles Bader
2008-06-29 4:22 ` Stefan Monnier
2008-06-29 4:43 ` Miles Bader
2008-06-29 4:47 ` Chong Yidong
2008-06-29 8:51 ` David Kastrup
2008-06-29 5:36 ` Stefan Monnier
2008-06-29 15:20 ` Richard M Stallman
2008-06-29 17:08 ` Chong Yidong
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 19:42 ` Stefan Monnier
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 4:30 ` Chong Yidong
2008-06-29 6:11 ` Stefan Monnier
2008-06-29 15:25 ` Chong Yidong
2008-06-29 18:00 ` Stefan Monnier
2008-06-29 19:24 ` Chong Yidong
2008-06-29 20:00 ` Stefan Monnier
2008-06-29 20:29 ` Chong Yidong
2008-06-30 0:58 ` Stefan Monnier
2008-06-30 2:24 ` Chong Yidong
2008-06-30 4:46 ` Stefan Monnier
2008-06-30 5:02 ` Chong Yidong
2008-06-30 14:43 ` Richard M Stallman
2008-06-29 2:48 ` Chong Yidong
2008-06-29 3:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd4m3fzd3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).