From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-git bug with top-level repositories Date: Wed, 27 Aug 2008 11:24:31 -0400 Message-ID: References: <200808181433.m7IEX8U3028640@sallyv1.ics.uci.edu> <200808181639.m7IGd1kb005968@sallyv1.ics.uci.edu> <200808182031.m7IKVbR7001754@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1219850971 32695 80.91.229.12 (27 Aug 2008 15:29:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Aug 2008 15:29:31 +0000 (UTC) Cc: dann@ics.uci.edu, ams@gnu.org, claus.klingberg@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 27 17:30:23 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KYMuC-0002lH-1U for ged-emacs-devel@m.gmane.org; Wed, 27 Aug 2008 17:25:56 +0200 Original-Received: from localhost ([127.0.0.1]:48585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYMtC-0000b8-Nt for ged-emacs-devel@m.gmane.org; Wed, 27 Aug 2008 11:24:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYMt8-0000Yl-UB for emacs-devel@gnu.org; Wed, 27 Aug 2008 11:24:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYMt7-0000UJ-46 for emacs-devel@gnu.org; Wed, 27 Aug 2008 11:24:50 -0400 Original-Received: from [199.232.76.173] (port=57200 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYMt6-0000Tv-UR for emacs-devel@gnu.org; Wed, 27 Aug 2008 11:24:48 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:56070) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYMss-0001wM-Es; Wed, 27 Aug 2008 11:24:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmsFAHEOtUhFxI/k/2dsb2JhbACBZLdxgWiBBw X-IronPort-AV: E=Sophos;i="4.32,279,1217822400"; d="scan'208";a="26039310" Original-Received: from 69-196-143-228.dsl.teksavvy.com (HELO pastel.home) ([69.196.143.228]) by ironport2-out.teksavvy.com with ESMTP; 27 Aug 2008 11:24:32 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 204717F21; Wed, 27 Aug 2008 11:24:31 -0400 (EDT) In-Reply-To: (Eli Zaretskii's message of "Wed, 20 Aug 2008 18:51:10 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:103020 Archived-At: >> >> ;; As a heuristic, we stop looking up the hierarchy of >> >> ;; directories as soon as we find a directory belonging >> >> ;; to another user. This should save us from looking in >> >> ;; things like /net and /afs. This assumes that all the >> >> ;; files inside a project belong to the same user. >> >> [...] >> >> > This assumption is only valid for Posix platforms... >> >> >> So in my case "c:/work/foo/bar/somefile" had a different owner than >> >> "c:/work/foo/bar" so Emacs stopped looking for .git further upwards --> no version control enabled. >> >> > ...as this case clearly shows. I think VC needs to limit this >> > heuristic to Posix platforms only. >> >> I do not see where is the Posixness of my assumption (presumably >> because Posix is basically all I know). Could you explain? > Perhaps I misunderstood, but the text above sounds like it assumes > that if /foo/bar/baz is owned by me, but /foo/bar is owned by someone > other than myself, /foo cannot be reasonably owned by me. I see. No it doesn't assume any such thing (this assumption is also invalid under Posix). It only assumes that a given checkout of a project is made of files entirely owned by a single user. >> The assumption of my heuristic is that all the files in a given project >> belong to the same user. Clearly there's nothing that guarantees it's >> always true, but for "programming projects", it's probably true in >> 99.9999% of the cases. If the "project" is a complete OS image OTOH, >> it's not going to work. > Well, in that case, perhaps you need to add an option to disable this > heuristic, since if someone is unfortunate enough to be in the alleged > 0.0001%, she will need a fire escape. Might be. I'd still like to know how the OP ended up in this situation, Stefan