From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-pretest-bug@gnu.org, Chong Yidong <cyd@stupidchicken.com>,
3269@emacsbugs.donarmstrong.com,
Thomas Christensen <thomasc@thomaschristensen.org>,
emacs-devel@gnu.org
Subject: Re: bug#3269: 23.0.93; C-mode text highlighting
Date: Tue, 19 May 2009 10:36:05 -0400 [thread overview]
Message-ID: <jwvd4a5yxck.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <20090519102619.GA1317@muc.de> (Alan Mackenzie's message of "Tue, 19 May 2009 10:26:19 +0000")
>> In other words, messed-up highlighting for incorrect code is just as
>> good if not better than explicitly recognizing the incorrect code and
>> highlighting it with f-l-warning-face.
> I was thinking of "compatibility" with unterminated strings in normal
> code. But they're not the same thing. An open string in a #define is
> perfectly valid code, if somewhat unusual outside of the Obfuscated C
> competition.
> You've persuaded me that the existing fontification is actually better.
> So I won't be committing yesterday's patch. Thanks!
I'm glad we ended up agreeing, tho for completely different reasons.
> I'll just finish the other patch and commit that.
Thanks,
Stefan
next prev parent reply other threads:[~2009-05-19 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <878wl1h5fw.fsf@ancient.thomaschristensen.org>
[not found] ` <20090514213924.GB2413@muc.de>
2009-05-18 15:06 ` bug#3269: 23.0.93; C-mode text highlighting Alan Mackenzie
2009-05-18 16:41 ` Chong Yidong
2009-05-18 21:16 ` Alan Mackenzie
2009-05-18 19:53 ` Stefan Monnier
2009-05-18 21:30 ` Alan Mackenzie
2009-05-19 2:24 ` Stefan Monnier
2009-05-19 10:26 ` Alan Mackenzie
2009-05-19 14:36 ` Stefan Monnier [this message]
2009-05-19 22:40 ` Alan Mackenzie
2009-05-20 10:31 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd4a5yxck.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=3269@emacsbugs.donarmstrong.com \
--cc=acm@muc.de \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=emacs-pretest-bug@gnu.org \
--cc=thomasc@thomaschristensen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).