unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Juri Linkov <juri@jurta.org>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: kill-ring visualization
Date: Tue, 30 Mar 2010 16:35:01 -0400	[thread overview]
Message-ID: <jwvd3yl8sbg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878w9akv49.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 30 Mar 2010 19:07:59 +0300")

>>>>> +	     ((eq completions-format 'line)
>>>>> +	      ;; One-line format
>>>>> +	      (setq str (query-replace-descr str)))
>>>> But this will not just change the string displayed, but also the string
>>>> inserted by the yank.  We need to distinguish the two.
>>> Maybe to put the `display' property with the value "^J" on newlines?
>> That would only work if this property is removed when the string in
>> subsequently inserted.
> In the patch I sent earlier, yank-pop doesn't insert the string selected
> from the *Completions* buffer.  It searches for selected completion string
> in the kill-ring (using `member' that ignores the `display' property),
> gets its position in the kill-ring, and calls `yank' with this position
> as a numeric index.

Yes, I noticed it, and the problem is that my yank happens to be advised
and that breaks it (because the advice occasionally adds elements to
the kill-ring).

So, while I also started with such an approach, I ended up going the
more straightforward route of inserting the actual selected text, since
it's more reliable.


        Stefan




  reply	other threads:[~2010-03-30 20:35 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  6:18 kill-ring visualization joakim
2010-03-18 14:06 ` Stefan Monnier
2010-03-18 18:39   ` Leo
2010-03-18 19:37     ` joakim
2010-03-24  9:34   ` Juri Linkov
2010-03-24 13:54     ` Stefan Monnier
2010-03-25  7:04       ` Juri Linkov
2010-03-25  9:47         ` Thierry Volpiatto
2010-03-25 10:13           ` joakim
2010-03-25 10:20             ` Thierry Volpiatto
2010-03-25 13:56               ` anything.el inclusion (was: kill-ring visualization) Ted Zlatanov
2010-03-25 17:28                 ` anything.el inclusion Juri Linkov
2010-03-26  6:37                   ` Thierry Volpiatto
2010-03-26  7:01                     ` Juri Linkov
2010-03-26  7:22                       ` Thierry Volpiatto
2010-03-26 20:19                         ` Stefan Monnier
2010-03-29 18:32                           ` Ted Zlatanov
2010-03-29 19:34                             ` Thierry Volpiatto
2010-04-03  5:44                               ` Thierry Volpiatto
2010-04-03 13:53                             ` Stefan Monnier
2010-04-03 14:17                               ` Thierry Volpiatto
2010-04-03 19:08                                 ` Stefan Monnier
2010-03-26 17:09                   ` Ted Zlatanov
2010-03-27 19:38                     ` Juri Linkov
2010-03-27 21:35                       ` Johan Busk Eriksson
2010-03-28  7:58                       ` Yoni Rabkin
2010-03-28 17:39                         ` joakim
2010-03-29 18:25                       ` Ted Zlatanov
2010-03-26  2:00         ` regexp completion (was: kill-ring visualization) Stefan Monnier
2010-03-25 17:29       ` kill-ring visualization Juri Linkov
2010-03-26  2:53         ` Stefan Monnier
2010-03-26  7:09           ` Juri Linkov
2010-03-26 20:17             ` Stefan Monnier
2010-03-27 19:42               ` Juri Linkov
2010-03-27 20:37                 ` Stefan Monnier
2010-03-30 16:07                   ` Juri Linkov
2010-03-30 20:35                     ` Stefan Monnier [this message]
2010-03-31 15:04                       ` Juri Linkov
2010-03-25 16:49     ` Drew Adams
2010-03-18 15:16 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd3yl8sbg.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).