From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Deniz Dogan <deniz.a.m.dogan@gmail.com>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] delete-trailing-whitespace on active region
Date: Wed, 09 Feb 2011 21:35:29 -0500 [thread overview]
Message-ID: <jwvd3n0wrei.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AANLkTi=pRUpJdGixFMQQV_Z0-CfqTSR86cDHmL7W0uey@mail.gmail.com> (Deniz Dogan's message of "Wed, 9 Feb 2011 19:28:35 +0100")
> + (interactive "*r")
Using "r" and then checking region-active-p sounds clever, but is wrong:
- "r" will fail if the mark has never been set in the current buffer.
- checking region-active-p is wrong in non-interactive use.
I.e. the `interactive' spec should do the region-active-p check.
Oh, and it should use use-region-p instead of region-active-p.
Stefan
next prev parent reply other threads:[~2011-02-10 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 18:28 [PATCH] delete-trailing-whitespace on active region Deniz Dogan
2011-02-10 2:35 ` Stefan Monnier [this message]
2011-02-10 15:31 ` Deniz Dogan
2011-02-10 19:05 ` Stefan Monnier
2011-02-10 21:31 ` Johan Bockgård
2011-02-11 2:10 ` Stefan Monnier
2011-02-11 6:33 ` Deniz Dogan
2011-02-11 14:30 ` Stefan Monnier
2011-02-11 18:27 ` Deniz Dogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd3n0wrei.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=deniz.a.m.dogan@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).