From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: rewriting y-or-n-p to use read-char-choice Date: Thu, 10 Mar 2011 21:05:27 -0500 Message-ID: References: <8739mulshy.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1299809139 8543 80.91.229.12 (11 Mar 2011 02:05:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2011 02:05:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 03:05:35 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PxrjT-00077Z-Cg for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2011 03:05:35 +0100 Original-Received: from localhost ([127.0.0.1]:46517 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxrjS-0005E7-RQ for ged-emacs-devel@m.gmane.org; Thu, 10 Mar 2011 21:05:34 -0500 Original-Received: from [140.186.70.92] (port=32781 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxrjO-0005Dr-0J for emacs-devel@gnu.org; Thu, 10 Mar 2011 21:05:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxrjM-0003EK-WD for emacs-devel@gnu.org; Thu, 10 Mar 2011 21:05:29 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:6977 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxrjM-0003EE-SC for emacs-devel@gnu.org; Thu, 10 Mar 2011 21:05:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAJMSeU3O+IG+/2dsb2JhbACmNHjBaIViBIUkkAk X-IronPort-AV: E=Sophos;i="4.62,300,1297054800"; d="scan'208";a="95611141" Original-Received: from 206-248-129-190.dsl.teksavvy.com (HELO ceviche.home) ([206.248.129.190]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 10 Mar 2011 21:05:27 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 404BD66135; Thu, 10 Mar 2011 21:05:27 -0500 (EST) In-Reply-To: <8739mulshy.fsf@lifelogs.com> (Ted Zlatanov's message of "Thu, 10 Mar 2011 12:50:33 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137071 Archived-At: > So I think a better way would be to write a > `read-char-choice-from-keymap' function which can be passed > `query-replace-map' or something else AND a prompt and a list of > acceptable return values. Using a keymap sounds good. It also means that the right way to implement it is by using read-key-sequence (temporarily overshadowing all the normal keymaps with the one provided). Stefan