unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Changes in revision 106420 reverted
@ 2011-11-19  8:46 Eli Zaretskii
  2011-11-19 13:55 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2011-11-19  8:46 UTC (permalink / raw)
  To: Paul Eggert; +Cc: emacs-devel

Sorry about that.

I reverted these because the functions I made external are explicitly
intended to be that.  I don't want to need to convert them back from
static when they are called from outside the module that defines them.
Hash codes of glyph rows are manipulated both in xdisp.c and in
dispnew.c, so the natural thing for these functions is to be external,
not static.

Besides, code like this:

 #if !XASSERTS
 static
 #endif
 unsigned
 row_hash (struct glyph_row *row)
 {

is butt-ugly, IMNSHO.  There's a limit to which we should go to pacify
overly-pedantic compiler switches, and this is way out.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-19 13:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-19  8:46 Changes in revision 106420 reverted Eli Zaretskii
2011-11-19 13:55 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).