From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: /etc/TODO: define-minor-mode & minor-mode-list Date: Thu, 02 Feb 2012 13:40:40 -0500 Message-ID: References: <877h07fgua.fsf@gmail.com> <87liolrad1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1328208049 17342 80.91.229.3 (2 Feb 2012 18:40:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 2 Feb 2012 18:40:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: William Stevenson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 02 19:40:48 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rt1aR-00057O-Bo for ged-emacs-devel@m.gmane.org; Thu, 02 Feb 2012 19:40:47 +0100 Original-Received: from localhost ([::1]:45315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt1aQ-0000Ds-Tt for ged-emacs-devel@m.gmane.org; Thu, 02 Feb 2012 13:40:46 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:34338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt1aO-0000Da-1j for emacs-devel@gnu.org; Thu, 02 Feb 2012 13:40:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rt1aM-0001ea-UM for emacs-devel@gnu.org; Thu, 02 Feb 2012 13:40:44 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:39513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt1aM-0001eT-PB for emacs-devel@gnu.org; Thu, 02 Feb 2012 13:40:42 -0500 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q12IeflO031416; Thu, 2 Feb 2012 13:40:41 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 069AC130004; Thu, 2 Feb 2012 13:40:40 -0500 (EST) In-Reply-To: <87liolrad1.fsf@gmail.com> (William Stevenson's message of "Thu, 02 Feb 2012 06:57:14 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4120=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4120> : streams <725169> : uri <1058591> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148124 Archived-At: >>> Also is this todo considered todone? >> Largely, yes. I did this during the Emacs-24 development (which lead to >> the addition of the `:variable' argument). My methodology to find >> potential minor modes was to grep for something like "defun.*-mode >> ([^)]" since traditionally minor modes take an argument, whereas major >> modes don't. There are a few cases I found which I haven't converted, >> usually because the conversion was less straightforward so I left it >> for later. These are: orgstruct++-mode, tcl-auto-fill-mode, >> vhdl-hs-minor-mode, speedbar-frame-mode, reftex-isearch-minor-mode, >> type-break-mode. >> There are probably other candidates, of course. > I searched for more but I've probably unearthed more false positives > than anything else. I'll hopefully have at least one patch by the end of > the week. Just to give you an idea of the kinds of problems you might have to deal with: changing orgstruct++-mode to use define-minor-mode should be fairly easy with the new `:variable' argument, but I suspect that the Org guys won't be happy with this since they want their code to work under Emacs-23 as well. Stefan