From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 01/10] move some globals into a thread object Date: Thu, 09 Aug 2012 21:18:58 -0400 Message-ID: References: <87vcgreu1s.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344561552 30133 80.91.229.3 (10 Aug 2012 01:19:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2012 01:19:12 +0000 (UTC) Cc: Emacs discussions To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 10 03:19:12 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SzdsX-0001c9-OJ for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2012 03:19:05 +0200 Original-Received: from localhost ([::1]:60078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzdsW-0001H0-K0 for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2012 21:19:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzdsU-0001GD-Bl for emacs-devel@gnu.org; Thu, 09 Aug 2012 21:19:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzdsS-000129-Cm for emacs-devel@gnu.org; Thu, 09 Aug 2012 21:19:02 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:2381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzdsS-00011z-8d for emacs-devel@gnu.org; Thu, 09 Aug 2012 21:19:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu0+4rw0x/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmLHIUoA6MzgViDBYE7 X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="195399352" Original-Received: from 184-175-13-49.dsl.teksavvy.com (HELO pastel.home) ([184.175.13.49]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 09 Aug 2012 21:18:59 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C65354E0AA; Thu, 9 Aug 2012 21:18:58 -0400 (EDT) In-Reply-To: <87vcgreu1s.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 09 Aug 2012 13:37:03 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152389 Archived-At: > The #defines mean that this patch also has to rename a few fields > whose names clash with the defines. I'd rather rename the globals (although I understand it will probably result in a larger patch), because I'd rather limit the impact of those #defines. If you ever create a local variable (or a struct field) named `current_buffer' somewhere, it might take you a good while to figure out why your code is misbehaving. Stefan