From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112045: * doc-view.el Fix bug#13887.
Date: Mon, 18 Mar 2013 09:23:44 -0400 [thread overview]
Message-ID: <jwvd2uw976h.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874ng9cfwl.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Mon, 18 Mar 2013 08:42:50 +0100")
>>> + ;; We're not already displaying an image, so this is the
>>> + ;; initial window showing the document.
>>> + (run-with-timer nil nil
>>> + (lambda ()
>>> + ;; In case a conversion is running, the
>>> + ;; refresh will happen as defined by
>>> + ;; `doc-view-conversion-refresh-interval'.
>>> + (unless doc-view-current-converter-processes
>>> + (with-selected-window (car winprops)
>>> + (doc-view-goto-page 1)))))
>> I don't understand the scenario in which this doc-view-goto-page would
>> be needed.
> This is the case where the document is initially shown in a window.
I must admit I do not know what you mean precisely with the above sentence.
> My change to `doc-view-insert-image' prevents insertion of image data
> if the window isn't shown,
Do you mean "if the window is not *live*" or "if the *buffer* isn't shown"?
> and here the `doc-view-goto-page' call will do just that.
But between the moment you checked window-live-p and the moment you run
the above timer, if the buffer ends up displayed, there must have been
an operation that ran window-configuration-change-hook.
So IIUC this doc-view-goto-page shouldn't be required because the
window-configuration-change-hook should have caused an equivalent
doc-view-goto-page already.
> I've adjusted the comment accordingly.
Thanks,
Stefan
next prev parent reply other threads:[~2013-03-18 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1UGGSd-000258-Pl@vcs.savannah.gnu.org>
2013-03-17 2:57 ` [Emacs-diffs] /srv/bzr/emacs/trunk r112045: * doc-view.el Fix bug#13887 Stefan Monnier
2013-03-18 7:42 ` Tassilo Horn
2013-03-18 13:23 ` Stefan Monnier [this message]
2013-03-18 19:50 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd2uw976h.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).