From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r114048: * src/eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically Date: Fri, 06 Sep 2013 08:18:23 -0400 Message-ID: References: <87bo46yai6.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1378469918 20149 80.91.229.3 (6 Sep 2013 12:18:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Sep 2013 12:18:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 06 14:18:41 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VHuzp-0007du-Ek for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2013 14:18:41 +0200 Original-Received: from localhost ([::1]:37197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHuzp-0003gI-1R for ged-emacs-devel@m.gmane.org; Fri, 06 Sep 2013 08:18:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHuze-0003Yd-OT for emacs-devel@gnu.org; Fri, 06 Sep 2013 08:18:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHuzY-0002iY-Qb for emacs-devel@gnu.org; Fri, 06 Sep 2013 08:18:30 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHuzY-0002iT-Lt for emacs-devel@gnu.org; Fri, 06 Sep 2013 08:18:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KK6/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBgzBIZEKA5cpjVGBXoMT X-IPAS-Result: Av4EABK/CFHO+KK6/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBgzBIZEKA5cpjVGBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="26646153" Original-Received: from 206-248-162-186.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.186]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Sep 2013 08:15:15 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 5C0B866CA6; Fri, 6 Sep 2013 08:18:23 -0400 (EDT) In-Reply-To: <87bo46yai6.fsf@yandex.ru> (Dmitry Gutov's message of "Fri, 06 Sep 2013 05:00:49 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163219 Archived-At: >> revision-id: monnier@iro.umontreal.ca-20130828182726-uq2hsj7b9v29tk7r >> parent: monnier@iro.umontreal.ca-20130828175712-4bbaymrusge69dpg >> fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11258 > This change lowers the performance of the js2-mode parser (which still > uses dynamic scoping, by the way) by the factor of five. That's very odd. I must be doing something wrong there. > Incidentally, the slowdown factor is similar to I've seen when trying to > measure its performance in lexical-binding mode before this revision. > pre-114048, lexical-binding: t -- 3.95 seconds > 114048+, lexical-binding: t -- 7-8 seconds > Should I file a dedicated bug? Yes. Stefan