From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r114390: * emacs-lisp/eieio.el (class-parent): Don't use defalias with macros.
Date: Thu, 19 Sep 2013 17:34:30 -0400 [thread overview]
Message-ID: <jwvd2o4ts5q.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <aeioxw6bjk.fsf@fencepost.gnu.org>
>>> + * emacs-lisp/eieio.el (class-parent): Don't use defalias with macros.
>> Why not?
> Because it didn't work.
> (defvar foo-var 0)
> (defmacro foo-mac ()
> '(setq foo-var (1+ foo-var)))
> (define-obsolete-function-alias 'old-mac #'foo-mac "24.4")
> (defun foo-fails ()
> (old-mac))
> (defun foo-works ()
> (foo-mac))
Oh, I see. We should probably fix this, but in any case the code after
define-obsolete-function-alias should be changed to use new-mac rather
than old-mac.
Stefan
prev parent reply other threads:[~2013-09-19 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VMYS7-0005m6-JR@vcs.savannah.gnu.org>
2013-09-19 14:06 ` [Emacs-diffs] trunk r114390: * emacs-lisp/eieio.el (class-parent): Don't use defalias with macros Stefan Monnier
2013-09-19 16:06 ` Glenn Morris
2013-09-19 21:34 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd2o4ts5q.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).