unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [RFC] Getting rid of selected_window
Date: Fri, 29 Nov 2013 09:38:35 -0500	[thread overview]
Message-ID: <jwvd2lje0yu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5298804A.5040405@yandex.ru> (Dmitry Antipov's message of "Fri, 29 Nov 2013 15:53:46 +0400")

> I'm trying to get rid of selected_window, with an intent to completely
> cleanup corner cases where FRAME_SELECTED_WINDOW (selected_frame) is
> not the same as selected_window and avoid redundant synchronization of
> them.  Comments are welcome.

Indeed, I think that the two are now 100% synchronized, so we should be
able to get rid of `selected-window'.
A few comments, tho:
- Shouldn't we replace uses of `selected_window' with a call to an
  inlined function?  I.e. either make Fselected_window inlinable?
- If you want SELECTED_WINDOW (which should be an inlined function),
  then I think we should define it as XWINDOW (Fselected_window ())
  rather than providing a redundant definition.
- SELECTED_BUFFER should be a function rather than a macro and
  it should return a Lisp_Object rather than a struct buffer*.
  

        Stefan



  reply	other threads:[~2013-11-29 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 11:53 [RFC] Getting rid of selected_window Dmitry Antipov
2013-11-29 14:38 ` Stefan Monnier [this message]
2013-11-29 15:19 ` Eli Zaretskii
2013-11-29 16:54   ` Stefan Monnier
2013-11-29 19:42     ` Eli Zaretskii
2013-12-02 14:37       ` Dmitry Antipov
2013-12-02 15:06         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvd2lje0yu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).