unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] 01/21: company-begin-commands: add `org-self-insert-command'
       [not found] ` <E1WANRP-0005F2-4P@vcs.savannah.gnu.org>
@ 2014-02-04  3:43   ` Stefan Monnier
  2014-02-04 11:52     ` Dmitry Gutov
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2014-02-04  3:43 UTC (permalink / raw)
  To: emacs-devel

> -(defcustom company-begin-commands '(self-insert-command)
> +(defcustom company-begin-commands '(self-insert-command org-self-insert-command)

One way to remove the need for org-self-insert-command is to check not
just (memq this-command company-begin-commands) but also check
(memq this-command
      (mapcar (lambda (cmd) (key-binding `[remap ,cmd]))
              company-begin-commands))


-- Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [elpa] 01/21: company-begin-commands: add `org-self-insert-command'
  2014-02-04  3:43   ` [elpa] 01/21: company-begin-commands: add `org-self-insert-command' Stefan Monnier
@ 2014-02-04 11:52     ` Dmitry Gutov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Gutov @ 2014-02-04 11:52 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> One way to remove the need for org-self-insert-command is to check not
> just (memq this-command company-begin-commands) but also check
> (memq this-command
>       (mapcar (lambda (cmd) (key-binding `[remap ,cmd]))
>               company-begin-commands))

Thank you, I'll keep this in mind the next time the issue comes up.
This could very well have been the last time, though: not many modes
remap self-insert-command, and putting other kinds of commands in this
variable is not very likely.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-04 11:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20140203173614.20092.2049@vcs.savannah.gnu.org>
     [not found] ` <E1WANRP-0005F2-4P@vcs.savannah.gnu.org>
2014-02-04  3:43   ` [elpa] 01/21: company-begin-commands: add `org-self-insert-command' Stefan Monnier
2014-02-04 11:52     ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).