From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: with-wrapper-hook is obsolete; how to replace it?
Date: Mon, 16 May 2016 13:40:33 -0400 [thread overview]
Message-ID: <jwvd1olzz0x.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 5738AB51.8030401@cs.ucla.edu
[ Hmm... I can't seem to see my reply, so I'll send it again. ]
> When I run ‘make compile-always’ from the lisp subdirectory I see diagnostics
> like this:
> In buffer-substring--filter:
> simple.el:4058:52:Warning: ‘with-wrapper-hook’ is an obsolete macro (as of
> 24.4); use a <foo>-function variable modified by ‘add-function’.
> How do I alter the code to use add-function instead?
Here's a translation table:
+---------------------+-----------------+----------------+
| with-wrapper-hook | foo-functions | add-hook |
+---------------------+-----------------+----------------+
| funcall | foo-function | add-function |
+---------------------+-----------------+----------------+
This replacement has already been done in buffer-substring, but we still
need to use the obsolete with-wrapper-hook in order to support the
corresponding obsolete filter-buffer-substring-functions variable.
Stefan
prev parent reply other threads:[~2016-05-16 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 17:01 with-wrapper-hook is obsolete; how to replace it? Paul Eggert
2016-05-15 18:43 ` Stefan Monnier
2016-05-16 18:18 ` Paul Eggert
2016-05-16 18:25 ` Stefan Monnier
2016-05-16 17:40 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvd1olzz0x.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).