From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Mon, 17 Apr 2017 08:14:58 -0400 Message-ID: References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> <87vaq79903.fsf@localhost> <83r30vh2k3.fsf@gnu.org> <83bmrwfg43.fsf@gnu.org> <8360i4f756.fsf@gnu.org> <8337d7fv9k.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492431345 19732 195.159.176.226 (17 Apr 2017 12:15:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 12:15:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 14:15:42 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d05ZE-00053B-Jy for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 14:15:40 +0200 Original-Received: from localhost ([::1]:36376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d05ZK-0003Hw-Bc for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 08:15:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d05Ym-0003Hp-Eb for emacs-devel@gnu.org; Mon, 17 Apr 2017 08:15:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d05Yh-0008DD-EO for emacs-devel@gnu.org; Mon, 17 Apr 2017 08:15:12 -0400 Original-Received: from [195.159.176.226] (port=38347 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d05Yh-00089u-8P for emacs-devel@gnu.org; Mon, 17 Apr 2017 08:15:07 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d05YY-0004Be-DA for emacs-devel@gnu.org; Mon, 17 Apr 2017 14:14:58 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:OUQHnVeaTzOZn+89S+psInBIl4E= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214053 Archived-At: >> By this measure, we can stop hacking on Emacs, > Not hacking, only bike-shedding. To me bike-shedding means that it's only an aesthetic issue, but in this case the ugliness has enough real consequences that you felt compelled to document them via: diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 208f4c2..1594270 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1904,7 +1904,10 @@ updating the menu." (defun kill-this-buffer () ; for the menu bar "Kill the current buffer. When called in the minibuffer, get out of the minibuffer -using `abort-recursive-edit'." +using `abort-recursive-edit'. + +This command can be reliably invoked only from the menu bar, +otherwise it could decide to silently do nothing." (interactive) (cond ;; Don't do anything when `menu-frame' is not alive or visible My patch (as fixed by Martin) fixes the problem instead of documenting the resulting quirks. While it's not terribly important, it's not just cosmetic. Stefan