From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make byte-compile-error-on-warn a safe variable for file compilation Date: Thu, 04 Jan 2018 22:51:41 -0500 Message-ID: References: <87wp0yhsgu.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515124281 9856 195.159.176.226 (5 Jan 2018 03:51:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 5 Jan 2018 03:51:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 05 04:51:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXJ2G-0001xC-Nd for ged-emacs-devel@m.gmane.org; Fri, 05 Jan 2018 04:51:12 +0100 Original-Received: from localhost ([::1]:41050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXJ4G-0004n9-2N for ged-emacs-devel@m.gmane.org; Thu, 04 Jan 2018 22:53:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXJ3I-0004l7-Bo for emacs-devel@gnu.org; Thu, 04 Jan 2018 22:52:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXJ3G-00034Q-IO for emacs-devel@gnu.org; Thu, 04 Jan 2018 22:52:16 -0500 Original-Received: from [195.159.176.226] (port=35367 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eXJ3G-00033d-BA for emacs-devel@gnu.org; Thu, 04 Jan 2018 22:52:14 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eXJ1B-0005zQ-0Z for emacs-devel@gnu.org; Fri, 05 Jan 2018 04:50:05 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 11 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:ox+se2uPOvrqU4FiOY7yfDdvNAY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221607 Archived-At: >> Attached is a patch that adds the variable `byte-compile-error-on-warn' >> to the safe variable list temporarily during calls to >> `byte-compile-file`, so that individual files can easily and simply >> include "byte-compile-error-on-warn: t" in their file local variables. > Wouldn't it be simpler and clearer to make it permanently safe? (PS > you can use #'booleanp instead of listing t and nil). Indeed. Stefan