From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Performance issue w/ `cl-loop`s `collect...into` Date: Sun, 08 Apr 2018 21:59:25 -0400 Message-ID: References: <41631665-6cd6-7096-8866-5ab9559a14ef@gmail.com> <1d5b85f5-62cd-f2f3-0b71-9e2a2cf2ef9e@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523239069 13631 195.159.176.226 (9 Apr 2018 01:57:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Apr 2018 01:57:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 09 03:57:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f5M40-0003QF-Q1 for ged-emacs-devel@m.gmane.org; Mon, 09 Apr 2018 03:57:45 +0200 Original-Received: from localhost ([::1]:47757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5M64-0006xK-0Q for ged-emacs-devel@m.gmane.org; Sun, 08 Apr 2018 21:59:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5M5r-0006vL-LE for emacs-devel@gnu.org; Sun, 08 Apr 2018 21:59:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5M5n-0001ME-PC for emacs-devel@gnu.org; Sun, 08 Apr 2018 21:59:39 -0400 Original-Received: from [195.159.176.226] (port=54524 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f5M5n-0001MA-Hd for emacs-devel@gnu.org; Sun, 08 Apr 2018 21:59:35 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1f5M3f-00036o-CE for emacs-devel@gnu.org; Mon, 09 Apr 2018 03:57:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:hzjrJIApbnMA20rUJj3f76mROkU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224446 Archived-At: > Here's a second, cleaner attempt that separates the `cl--loop-handle-accum` > function into two functions, one to deal with lists and one to deal w/ > non-lists. > The tail-tracking optimizing is also applied to `append(ing)` and > `nconc(ing)`. Thanks. Looks good. I see you've dropped the (eq var cl--loop-accum-var) optimization. Have you tried to measure the effect? Stefan > +(defun cl--loop-handle-accum (def) [...] > + (cond [...] > + (cl--loop-accum-var cl--loop-accum-var) You can write this line as just (cl--loop-accum-var) -- Stefan