From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7cfe2dc: In edebug in GUIs, move focus to the selected frame. Date: Fri, 19 Oct 2018 13:58:44 -0400 Message-ID: References: <20181019175416.10874.88992@vcs0.savannah.gnu.org> <20181019175418.27D6920407@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539971869 24805 195.159.176.226 (19 Oct 2018 17:57:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Oct 2018 17:57:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 19 19:57:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDZ1t-0006Lz-EH for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 19:57:45 +0200 Original-Received: from localhost ([::1]:52078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDZ3z-0000Jj-Vi for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 13:59:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDZ2v-0000IK-Ee for emacs-devel@gnu.org; Fri, 19 Oct 2018 13:58:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDZ2s-0004rl-4b for emacs-devel@gnu.org; Fri, 19 Oct 2018 13:58:49 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:36922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDZ2r-0004r1-Uo for emacs-devel@gnu.org; Fri, 19 Oct 2018 13:58:46 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w9JHwiV9012770; Fri, 19 Oct 2018 13:58:44 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 21F0BAE152; Fri, 19 Oct 2018 13:58:44 -0400 (EDT) In-Reply-To: <20181019175418.27D6920407@vcs0.savannah.gnu.org> (Alan Mackenzie's message of "Fri, 19 Oct 2018 13:54:17 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered BODY_START_GREETING=0.1, EDT_SA_DN_PASS=0, RV6399=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6399> : inlines <6936> : streams <1801781> : uri <2733860> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230501 Archived-At: Hi Alan, > (edebug-pop-to-buffer edebug-buffer) > + (edebug-focus-frame (window-frame (selected-window))) [...] > - (edebug-pop-to-buffer edebug-buffer (car edebug-window-data))))) > + (edebug-pop-to-buffer edebug-buffer (car edebug-window-data)) > + (edebug-focus-frame (window-frame (selected-window)))))) [...] > - (edebug-pop-to-buffer edebug-eval-buffer)) > + (edebug-pop-to-buffer edebug-eval-buffer) > + (edebug-focus-frame (window-frame (selected-window)))) Maybe edebug-pop-to-buffer should call edebug-focus-frame? Stefan