From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Date: Fri, 18 Jan 2019 07:49:08 -0500 Message-ID: References: <20180922154639.23195.66360@vcs0.savannah.gnu.org> <20180922154640.9D58220310@vcs0.savannah.gnu.org> <54108dbc-9d12-06ff-3f1d-151118e9b234@yandex.ru> <385f6543-2214-101c-30b8-a8115a8dbede@yandex.ru> <87zhsi7mlt.fsf@mail.linkov.net> <07e843c5-70ea-20e6-96c9-263ea78e113f@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1547815739 14319 195.159.176.226 (18 Jan 2019 12:48:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Jan 2019 12:48:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Juri Linkov To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 18 13:48:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkTZu-0003aH-Ve for ged-emacs-devel@m.gmane.org; Fri, 18 Jan 2019 13:48:55 +0100 Original-Received: from localhost ([127.0.0.1]:38261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTc1-0005vo-RL for ged-emacs-devel@m.gmane.org; Fri, 18 Jan 2019 07:51:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTaD-0005e3-Ic for emacs-devel@gnu.org; Fri, 18 Jan 2019 07:49:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkTaC-0001mz-IZ for emacs-devel@gnu.org; Fri, 18 Jan 2019 07:49:13 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTaC-0001ls-E5 for emacs-devel@gnu.org; Fri, 18 Jan 2019 07:49:12 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0ICn8Hm028051; Fri, 18 Jan 2019 07:49:09 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id AC8826AB93; Fri, 18 Jan 2019 07:49:08 -0500 (EST) In-Reply-To: <07e843c5-70ea-20e6-96c9-263ea78e113f@yandex.ru> (Dmitry Gutov's message of "Fri, 18 Jan 2019 06:52:12 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6464=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6464> : inlines <6997> : streams <1810438> : uri <2781838> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232455 Archived-At: > I'm not adding this to master because this does not support > project-vc-ignores (or grep-find-ignored-files). Not sure why you think it should obey grep-find-ignored-files, but I think the project-vc-ignores variable is an error: project-vc-ignores should be a function that returns the set of files ignored by the underlying VCS, not something that the user sets in Emacs. So I think the code you sent which uses `git ls-files` is doing the right thing (it correctly ignores those files which project-vc-ignores should return). Stefan