From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: BIKESHED: completion faces Date: Sun, 03 Nov 2019 18:30:07 -0500 Message-ID: References: <4c5631d4-9dfd-04c6-c573-b83c67fcc2fa@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160167"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 04 00:30:46 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iRPKW-000fTV-Rd for ged-emacs-devel@m.gmane.org; Mon, 04 Nov 2019 00:30:45 +0100 Original-Received: from localhost ([::1]:56896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRPKU-0003UH-SV for ged-emacs-devel@m.gmane.org; Sun, 03 Nov 2019 18:30:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38523) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRPK1-0003U5-0b for emacs-devel@gnu.org; Sun, 03 Nov 2019 18:30:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRPJz-0007nl-Ib for emacs-devel@gnu.org; Sun, 03 Nov 2019 18:30:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34013) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iRPJz-0007nZ-Ce for emacs-devel@gnu.org; Sun, 03 Nov 2019 18:30:11 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 773784497DE; Sun, 3 Nov 2019 18:30:10 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 31C6C4497D9; Sun, 3 Nov 2019 18:30:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572823809; bh=Gso15ZFZe6+G7m0lbZnoW93EbNFsbw822My6GxedR/Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=c6/rBaIRJt6UzNIGqX4K0in/cGh5lH+NSrRpjMoSq2J8koQ8c94Z7KtU9ATsW/i6X Qsu4QpQvCnmuEIOgUnNlA2shJ2Fng7kdTwg3ZzQkz+5cypmpjmyGvLhyqVEh6z6LGG 69pwEILI7RtcX2LvyrXiPNtWt0petyUW9nuRmDmxFUqwUCmKBV+v3Yc1pZ+iIY0Yvm w71XEBqnjC0UYQfk0KnJyr37sbwM9FSAOCOVoUcDmso5w1VdTRXTsrx8FzbOrnTvNy zUZcKLnlDq17aKpMd7K2f7GRhgtaKkFgB7OEZXfDdKulAdn5zQa4VAzMFVv+f4r12D iBt6DBVJf1cJw== Original-Received: from alfajor (unknown [45.72.173.20]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD68212066A; Sun, 3 Nov 2019 18:30:08 -0500 (EST) In-Reply-To: <4c5631d4-9dfd-04c6-c573-b83c67fcc2fa@yandex.ru> (Dmitry Gutov's message of "Sun, 3 Nov 2019 23:53:19 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241772 Archived-At: > Further, none of the other systems AFAIK use a fallback list of completion > styles. So normally the matching is fuzzy to begin with, and in that case, > highlighting the matches is moderately useful. > > They won't see a situation with a long list of simple prefix matches where > the first column is highlighted uniformly. Indeed, part of the issue is the difference between something like `basic` and something like `flex`: in `basic` the completions-common-part is not terribly interesting, whereas in `flex` it's much more so. We could use different faces in those two cases, but I feel like it would be better if we can find a default that works well in both cases. > I'm more against using bold for the common part. Underline is > less aggravating. Hmm... sadly, I find underlying the completions-common-part to be pretty awful. So it looks like both bold and underline are out? Should we look for colors (background? foreground?)? >> M-x dovi C-b C-b ? >> you'll see that `completions-first-difference` is applied to the "c" >> of the "doc-view..." commands because that's the first character after >> the position in the candidate that corresponds to the position of >> point in the pattern. > > I'm having trouble reproducing this. Should I be using icomplete-mode? No, just `emacs -Q` and then `M-x dovi C-b C-b ?` > So I get what you're hinting at, in theory, but these cases should indeed be > rare. And there might be other things we could do about them. Agreed, I was just pointing out some corner-case behavior. It's of no consequence for the current discussion. Stefan