From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch, review request] better dired-isearch-filenames reset in dired-isearch-filenames-end Date: Thu, 28 Nov 2019 11:07:21 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193273"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: juri@linkov.net To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 28 17:08:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iaMLC-000o8W-1p for ged-emacs-devel@m.gmane.org; Thu, 28 Nov 2019 17:08:26 +0100 Original-Received: from localhost ([::1]:50454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaML8-0002hQ-Qh for ged-emacs-devel@m.gmane.org; Thu, 28 Nov 2019 11:08:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34121) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaMKQ-0002en-VC for emacs-devel@gnu.org; Thu, 28 Nov 2019 11:07:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaMKJ-0004Mp-1g for emacs-devel@gnu.org; Thu, 28 Nov 2019 11:07:35 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57282) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iaMKI-0004DV-QM for emacs-devel@gnu.org; Thu, 28 Nov 2019 11:07:30 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E42FF44A409; Thu, 28 Nov 2019 11:07:27 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 76D3944A405; Thu, 28 Nov 2019 11:07:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1574957242; bh=OTmNHy50MBn0VjUETHaX04wj5tVi0VLXeUbuBeONPxU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cEMq+qCHn5aVOifG2VYIgQ0yCTa7Y8Q2/rwxHVvfMxn2LrKoyBhl1lihz6MUmzGcK QqYYRRr5INaA39FOjn81KZOu52qnPVixaagv0VVIlYBog9s5Te3Z/WcihzFc644zIn 7X+/B/VeKNEnUKQqbk3FDBqvyP1EQ91hdVwqr2SbuJvLTHCgH0sxNHHZfLZu8AdcEc BbUi9AEeAqGVgeMON9M+ru9Ofq4lVcCvn5y6HXRMtpxsZeU5B+bDvQyROcBDRdH2lB RpCVHQwqgzjkjdSPcxTdfTmYp4UYGNM6nUvFS2Y5VrFFix/KG7OfQzamMD5YfDu0od vVXDbJkQBNH+w== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 552BC1203B5; Thu, 28 Nov 2019 11:07:22 -0500 (EST) In-Reply-To: (Filipp Gunbin's message of "Thu, 28 Nov 2019 17:13:08 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242836 Archived-At: > Current code calls custom-reevaluate-setting (bug#30187), and that > results in wrong value when dired-isearch-filenames was initialized not > with emacs customization facility, but with plain setq in .emacs. I > think a temporary local variable is a better way to save & restore the > global setting, WDYT? In my tests what worked well. Using custom-reevaluate-setting seems like a bad idea here, indeed. It's really only meant to update settings that were evaluated "too early" (i.e. during the dump). Stefan