From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f51f963: Fix some side-effecting uses of make-text-button Date: Sat, 06 Jun 2020 13:57:42 -0400 Message-ID: References: <20200604223056.17078.81265@vcs0.savannah.gnu.org> <20200604223058.1850020A26@vcs0.savannah.gnu.org> <87eeqtiy4x.fsf@tcd.ie> <87img51y04.fsf@gmail.com> <5c66eeb5-a513-0443-4316-e41aae118677@cs.ucla.edu> <87img4zjy7.fsf@gmail.com> <170bedfa-7119-4d6a-9d4f-e94ba0f7cc2b@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="47296"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , Paul Eggert , Pip Cet , emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 06 19:58:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhd5U-000CBs-6f for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jun 2020 19:58:32 +0200 Original-Received: from localhost ([::1]:34104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhd5T-0007rU-AG for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jun 2020 13:58:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhd4m-0007S1-8x for emacs-devel@gnu.org; Sat, 06 Jun 2020 13:57:48 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhd4k-0004aS-Mj for emacs-devel@gnu.org; Sat, 06 Jun 2020 13:57:47 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 54BB380BB9; Sat, 6 Jun 2020 13:57:45 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B8A4480605; Sat, 6 Jun 2020 13:57:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1591466263; bh=8ddzwL+VJU+NQ0UOe77uYnASsAfX/NmqNHxSd1murCw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gf0eP21HesR/zkycgxuvIRH5lLF6+APw6UOmkkvaTrlBRd6JkbYU8fEG3W9si1+1p 3PmzFpxqMJcREWYt4XpNy98D9yTd+f4xNGr6q+KVc1u1Yj5HyYw9uAypPXQhml4Ww4 5mQbDCIt2tqBYKR4QUXzBMP5RbBHlej8BFo3bpznv9SImJE9WmY+jQ9EfTGPJpOJWq 5S6MPuUtZN7HqKj8+0Haurzh9bXy5qpvgl0jj1seF7gxAilKP95+cKpT6/201T9UU6 uNsjnN6VIk+miMFNjKgg9d83QoY+fUEQrsWzixrVTBrk/21vf72ATbOzJheE/pr7uO 4uqtmfEv9j2mQ== Original-Received: from alfajor (unknown [157.52.17.179]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6B57E12029A; Sat, 6 Jun 2020 13:57:43 -0400 (EDT) In-Reply-To: <170bedfa-7119-4d6a-9d4f-e94ba0f7cc2b@default> (Drew Adams's message of "Sat, 6 Jun 2020 09:57:23 -0700 (PDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/06 13:57:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251956 Archived-At: > But going backwards, toward some perhaps unneeded > optimization, in the direction of systematically > raising an error when trying to modify text > properties of a string, is not a good idea, IMO. I think there needs to be a clarification here: the issue is about modifying data (here specifically strings, but the issue applies to all other such data) that appears as literal in the code. This issue is not one of optimization (preventing those modifications would likely impose a slowdown, if anything) but one of detecting usage that is usually a bug (one that leads to people being utterly confused by the resulting behavior). Stefan