From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2 15/16] Remove local_flags array in struct buffer Date: Sun, 22 Nov 2020 15:04:06 -0500 Message-ID: References: <20201119153814.17541-1-sbaugh@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26318"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Arnold Noronha , Dmitry Gutov , emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 22 21:05:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgvcF-0006ib-Mc for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Nov 2020 21:05:43 +0100 Original-Received: from localhost ([::1]:40264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgvcE-00026s-QH for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Nov 2020 15:05:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgvam-0001a6-7P for emacs-devel@gnu.org; Sun, 22 Nov 2020 15:04:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgvaj-0003cf-M3 for emacs-devel@gnu.org; Sun, 22 Nov 2020 15:04:12 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E1A9A4405F9; Sun, 22 Nov 2020 15:04:08 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9FC194405F1; Sun, 22 Nov 2020 15:04:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1606075447; bh=wFkIXB4+Ze0sfBrHGBdWKT21KU7SEpvvCQeGd1NRhbE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Kmw4IIMcopc9qbX0pTdFPD7hjl9DCZmtVMhtwDTzaSAA3iRAHtjEF5aQJAlhJoLvo cXOjgkAR/wPKeUjM8AJKapZbUbod5C11hEcSu0/E30hjKQ31POgHCX42W4DZJAbDU1 K0cVshlkIlVZrYVnnR9cDDKR1rv4+dz6yxOtSV+PpRMiQz8heK4dd41lVILWE9Ypg4 39uqK1OaGFqJ52MHIMIXxYhvBqQiaD+TuZFQlk0GnB6mnK8UcT/mfM+Hu/9emTYtwR X4Kg5h5nTrzTGRTA6Tvf0p39YokhP03d8DX4qo74iEQeACq9MmJGyYPyreEbOXWLam EonyAsTMzrEgw== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5AEFC12014D; Sun, 22 Nov 2020 15:04:07 -0500 (EST) In-Reply-To: (Spencer Baugh's message of "Sat, 21 Nov 2020 21:34:44 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259648 Archived-At: > Previously, we used the local_flags array in each struct buffer to > know which field was buffer-local. Now, we just set the field to > Qunbound if it's not buffer-local, and fall back to the corresponding > field in buffer_defaults. So we can delete the local_flags array. That's actually the approach I had in mind in my list of "things I should do at some point" ;-) I haven't had a chance to look at the actual patches yet, tho. Stefan