From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Compatibility patches for EDE / EIEIO Date: Sun, 17 Jan 2021 17:16:17 -0500 Message-ID: References: <5cf47a13-e71f-6f3b-f763-335696989942@siege-engine.com> <55bf727a-761c-ff52-7688-8946a3df1d86@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2714"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Eric Ludlam To: Eric Ludlam Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 17 23:17:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1GM8-0000ab-6q for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 23:17:08 +0100 Original-Received: from localhost ([::1]:44750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1GM7-0003xF-9H for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 17:17:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1GLV-00038h-NZ for emacs-devel@gnu.org; Sun, 17 Jan 2021 17:16:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1GLT-000519-Op for emacs-devel@gnu.org; Sun, 17 Jan 2021 17:16:29 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F362A101C9B; Sun, 17 Jan 2021 17:16:25 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 964C110021D; Sun, 17 Jan 2021 17:16:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1610921784; bh=8j6yBJ0egHn0+O6nfpV1nBV1HWPek8auoITR/rmcLWM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Xl96BV1e5E9msOcL+azGis5791oiAnqbhJEAiwGVA9weSnpewjQsJQBwoXpRGlFVY UaponI0Wo0nJlVX+2jflMNq5dQFamd+I/xW4FWLmPrL4tXds/XGsTfEks1LLiYBn7K xj13mgbHGMEI79kvs0macs0nmtm7AJTeJXABV1WN3yl/1GQzSz095NuHwKSolZdfx6 4Joxiemz3Ywsl6KE9HAWNLfWKdX7L+uc+keuHw4VmxJA0Jkh1aPTAxyFcGeNXh+cv7 i2qobPcSMo+ZKnnu/0Z0giLNq9edEi7qh6+rhSqHGbTmSXmESABZyWJAytMVbN+1ci E1U+XxvAo4EOA== Original-Received: from alfajor (unknown [45.72.224.181]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5F70312034B; Sun, 17 Jan 2021 17:16:24 -0500 (EST) In-Reply-To: <55bf727a-761c-ff52-7688-8946a3df1d86@gmail.com> (Eric Ludlam's message of "Sun, 17 Jan 2021 14:57:37 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263135 Archived-At: Hi Eric, > +(unless (fboundp 'ede-makefile-rule-p) > + (cl-deftype ede-makefile-rule-list () '(list-of ede-makefile-rule))) I don't understand the (fboundp 'ede-makefile-rule-p) test, maybe it deserves a comment? > (defclass ede-proj-target-makefile (ede-proj-target) > ((makefile :initarg :makefile > :initform "Makefile" > @@ -184,7 +187,7 @@ ede-proj-target-makefile > commands where the variable would usually appear.") > (rules :initarg :rules > :initform nil > - :type list > + :type ede-makefile-rule-list How 'bout using :type (list-of ede-makefile-rule) ? Stefan