From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eric Ludlam <ericludlam@gmail.com>
Cc: emacs-devel@gnu.org, Eric Ludlam <eric@siege-engine.com>
Subject: Re: Compatibility patches for EDE / EIEIO
Date: Sun, 17 Jan 2021 17:16:17 -0500 [thread overview]
Message-ID: <jwvczy3jjmj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <55bf727a-761c-ff52-7688-8946a3df1d86@gmail.com> (Eric Ludlam's message of "Sun, 17 Jan 2021 14:57:37 -0500")
Hi Eric,
> +(unless (fboundp 'ede-makefile-rule-p)
> + (cl-deftype ede-makefile-rule-list () '(list-of ede-makefile-rule)))
I don't understand the (fboundp 'ede-makefile-rule-p) test, maybe it
deserves a comment?
> (defclass ede-proj-target-makefile (ede-proj-target)
> ((makefile :initarg :makefile
> :initform "Makefile"
> @@ -184,7 +187,7 @@ ede-proj-target-makefile
> commands where the variable would usually appear.")
> (rules :initarg :rules
> :initform nil
> - :type list
> + :type ede-makefile-rule-list
How 'bout using
:type (list-of ede-makefile-rule)
?
Stefan
next prev parent reply other threads:[~2021-01-17 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 16:52 Compatibility patches for EDE / EIEIO Eric Ludlam
2021-01-11 21:21 ` Stefan Monnier
2021-01-17 19:57 ` Eric Ludlam
2021-01-17 22:16 ` Stefan Monnier [this message]
2021-01-18 16:52 ` Eric Ludlam
2021-01-18 17:52 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvczy3jjmj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=eric@siege-engine.com \
--cc=ericludlam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).