From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 8f28a1b: Tweak `condition-case' keyword highlights Date: Sun, 24 Jan 2021 18:10:47 -0500 Message-ID: References: <20210124203118.16450.28084@vcs0.savannah.gnu.org> <20210124203120.0ABC320AD1@vcs0.savannah.gnu.org> <87o8heovpm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10170"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 25 00:16:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3ocI-0002Y0-2U for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Jan 2021 00:16:22 +0100 Original-Received: from localhost ([::1]:49668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3ocG-0007x1-VG for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Jan 2021 18:16:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3oX0-0006yn-2y for emacs-devel@gnu.org; Sun, 24 Jan 2021 18:10:54 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3oWx-0000XN-U2 for emacs-devel@gnu.org; Sun, 24 Jan 2021 18:10:53 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F2BFE80B69; Sun, 24 Jan 2021 18:10:49 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8F6C180229; Sun, 24 Jan 2021 18:10:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611529848; bh=i/J/z/kZzXEFF+PB1xGHqDmc/5SKYqGDE6uXZE9TG1E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=B1SqZ0nCsc9Lz0cyX4uO4XagI74cfsZD80kaUGxt81KKYjqculfjsGGaEe02ZTEFM VAev4gwwDv9BS1tHYcHku16eB1lLgdDy9SfJ5pOpJbBJjivwPWC3ljBQ4TdgnK+vsQ SMkUSt3W99Z302DYQqlv4q4h244CTMi/bIWYBlQUh5vtbcK7cUw6BHlvaulKVI/YUE d6gW8X0Sz0zaiIDF72bfZNYYolCZPX5TbfnYYH4CgzmaZKkN+Kcr83My/4WgVa91tY 4UvYO41DENETLRI0kOTKYz66F7F0KC+C4gHERUtRp24EAReq5aFTG+qPSoKb760yc7 29M3apZgA0AgQ== Original-Received: from alfajor (69-196-141-46.dsl.teksavvy.com [69.196.141.46]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 28A6912019C; Sun, 24 Jan 2021 18:10:48 -0500 (EST) In-Reply-To: <87o8heovpm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 24 Jan 2021 22:45:25 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263366 Archived-At: > But speaking of other code that's mis-highlighted still: > > (defun a (when b c) > ...) > > (The `when' isn't a keyword here, but it's font-locked as such.) Yes, that one annoys me fairly often (typically with an arg named `function`). > Couldn't we just use `edebug-form-spec' to notice that the arglist isn't > a funcall position? In theory, yes. That could cover `condition-case` as well ;-) I think it'd be nice to use this spec for other things than just debugging [ I remember a discussion a few .. months? .. back where another possible use came up... oh yes, it was in the discussion about preserving source-code location, where we could make use of this info in order to know when the sexp is "code" which can then come with extra annotations vs "data" in which case we need the unannotated sexp. ] Stefan